Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Agones install to use Helm agones.allocator.labels #173

Closed
markmandel opened this issue Jun 13, 2023 · 4 comments · Fixed by #215
Closed

Switch Agones install to use Helm agones.allocator.labels #173

markmandel opened this issue Jun 13, 2023 · 4 comments · Fixed by #215
Assignees
@markmandel
Labels
cleanup General cleanup
Milestone
0.2.0

Comments

@markmandel
Copy link
Member

Agones install now has https://agones.dev/site/docs/installation/install-agones/helm/#configuration:~:text=agones.allocator.labels as part of the Helm install - so we don't have to use patching with Kustomize anymore.

We should switch over (and update Agones at the same time)
@markmandel markmandel added the cleanup General cleanup label Jun 13, 2023
@markmandel
Copy link
Member Author

Agones has been updated! So we are one step closer.

@markmandel
Copy link
Member Author

For context, this is all the patching we can get rid of:

global-multiplayer-demo/infrastructure/files/agones/agones-install.yaml.tpl

Lines 26 to 41 in f3892dd

patches:
- target:
kind: Deployment
name: agones-allocator
patch: |-
apiVersion: apps/v1
kind: Deployment
metadata:
name: agones-allocator
namespace: agones-system
spec:
template:
metadata:
labels:
istio.io/rev: asm-managed #ASM managed dataplane channel
region: ${location} #Region to identify the POD and send traffic

@markmandel
Copy link
Member Author

I would be curious if we could just go straight to helm rather than going kustomize -> helm like we do now as well.

@markmandel markmandel added this to the 0.2.0 milestone Aug 15, 2023
@markmandel markmandel self-assigned this Oct 13, 2023
@markmandel
Copy link
Member Author

Started work on this so we can do a 0.2.0 release.

markmandel added a commit to markmandel/global-multiplayer-demo that referenced this issue Oct 17, 2023
@markmandel
Agones: Use Helm agones.allocator.label
b82b004 
This removes the use of Kustomize patch to implement the appropriate
labels for ASM, and instead use the Helm configuration options that are
available in the latest versions of Agones.

Closes googleforgames#173
@markmandel markmandel mentioned this issue Oct 17, 2023
Merged
markmandel added a commit that referenced this issue Oct 17, 2023
@markmandel
Agones: Use Helm agones.allocator.label (#215)
168810e 
This removes the use of Kustomize patch to implement the appropriate
labels for ASM, and instead use the Helm configuration options that are
available in the latest versions of Agones.

Closes #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
cleanup General cleanup
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Agones: Use Helm agones.allocator.label markmandel/global-multiplayer-demo
1 participant
@markmandel