-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not parse packets as utf8 #151
Comments
Agreed, they should probably be something more like:
|
You are going to laugh. I literally JUST hit this issue writing the compression filter. Looks like I'm implementing a fix! |
I'm thinking it makes more sense to remove the log lines rather than work around it? Currently it seems to be unneeded work to try to parse every packet and create a log record each time only to discard it, especially since metrics tracks that info already. |
I honestly find it really useful when debugging issues found by integration tests, because I can see where in the flow packets are failing. |
The current debug logging assumes a packet is utf-8, and if not, it panics, which is bad. This provides a fallback output if the packet is not utf-8, and introduces a `debug` module to add tools to for debug builds and debugging in general. Closes #151
I think this relates to #153 outcome in that since the log messages are only needed during development we can compile them entirely away? I'm thinking then we can log them at level |
The current debug logging assumes a packet is utf-8, and if not, it panics, which is bad. This provides a fallback output if the packet is not utf-8, and introduces a `debug` module to add tools to for debug builds and debugging in general. Closes #151
* Don't panic on debug when packets aren't utf-8 The current debug logging assumes a packet is utf-8, and if not, it panics, which is bad. This provides a fallback output if the packet is not utf-8, and introduces a `debug` module to add tools to for debug builds and debugging in general. Closes #151 * Review updates.
In some parts of session.rs and server/mod.rs we currently try to parse packets as utf8 and will fail to do so and panic with raw bytes. We likely need to remove these lines
The text was updated successfully, but these errors were encountered: