-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List stores by alphabetical order if location is not given in the request #117
List stores by alphabetical order if location is not given in the request #117
Conversation
Did you pull #104 which temporarily fixed the server test ordering issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the failed test cases.
@@ -38,11 +38,6 @@ app.use((err, req, res, next) => { | |||
app.use(compression()); | |||
|
|||
const server = app.listen(PORT, function () { | |||
console.log(config.ENV); | |||
if (config.ENV === config.TEST) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify: I intended this to be here for testing with yarn start_test
which is set up to use the emulated firestore DB rather than our live DB. But maybe there is a better place to put this initialization code on server startup.
List stores by alphabetical order if location is not given in the request
Implemented a query limit for performance, but maybe this should be removed?
Other options for fallbacks if user doesn't share their location:
Unresolved: jest continues to detect open handles, as described in greater detail in #100