Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed double click on AutocompleteAddressActivity.java #449

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: fixed double click on AutocompleteAddressActivity.java #449

merged 1 commit into from
Dec 12, 2022

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Nov 29, 2022

The current Pull Request fixes an issue with the AC Intent can get called multiple times due to multiple clicks. See video attached.

Screen.Recording.2022-11-29.at.11.46.40.mov
  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #181

@kikoso kikoso added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 29, 2022
@kikoso kikoso requested a review from wangela November 29, 2022 10:49
@kikoso kikoso mentioned this pull request Nov 29, 2022
Closed
@wangela wangela merged commit f0c73d3 into main Dec 12, 2022
@wangela wangela deleted the fix/fix-double-click-on-autocomplete-address branch December 12, 2022 20:34
@wangela
Copy link
Collaborator

wangela commented Dec 12, 2022

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete Address Form sample: Multiple AC intents can open
2 participants
@kikoso @wangela