Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove theme picker #457

Merged
merged 2 commits into from
Dec 19, 2022
Merged

chore: remove theme picker #457

merged 2 commits into from
Dec 19, 2022

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Dec 18, 2022 •
edited
Loading

  • Removing completely the theme picker.
  • Applies new AS indentation for each edited file.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #118 🦕

Deprecates #456

@kikoso kikoso added type: cleanup An internal cleanup or hygiene concern. samples Issues that are directly related to samples. labels Dec 18, 2022
@kikoso kikoso requested a review from wangela December 18, 2022 10:48
@kikoso kikoso assigned wangela and unassigned amuramoto Dec 18, 2022
@kikoso kikoso mentioned this pull request Dec 18, 2022
Closed
4 tasks
@wangela wangela merged commit e0a0e69 into main Dec 19, 2022
@wangela wangela deleted the chore/remove-theme-picker branch December 19, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: all buttons in the sample of Kotlin&v3 cause a crash
3 participants
@kikoso @wangela @amuramoto