Skip to content

Commit

Permalink
fix: make DefaultMapProperties, DefaultMapUiSettings, and NoPadding p…
Browse files Browse the repository at this point in the history
…ublic (#514)

* fix: make DefaultMapProperties, DefaultMapUiSettings, and NoPadding public

Fixes #513

* Rename NoPadding to DefaultMapContentPadding
Add documentation for DefaultMapProperties, DefaultMapUiSettings, and DefaultMapContentPadding

---------

Co-authored-by: Uli Bubenheimer <bubenheimer@users.noreply.github.com>
  • Loading branch information
bubenheimer and bubenheimer committed Jun 4, 2024
1 parent f7311b4 commit 0a03820
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public fun GoogleMap(
onMyLocationButtonClick: (() -> Boolean)? = null,
onMyLocationClick: ((Location) -> Unit)? = null,
onPOIClick: ((PointOfInterest) -> Unit)? = null,
contentPadding: PaddingValues = NoPadding,
contentPadding: PaddingValues = DefaultMapContentPadding,
content: @Composable @GoogleMapComposable () -> Unit = {},
) {
// When in preview, early return a Box with the received modifier preserving layout
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ import com.google.android.gms.maps.model.LatLngBounds
import com.google.android.gms.maps.model.MapStyleOptions
import java.util.Objects

internal val DefaultMapProperties = MapProperties()
/**
* Equivalent to [MapProperties] with default values.
*/
public val DefaultMapProperties: MapProperties = MapProperties()

/**
* Data class for properties that can be modified on the map.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ package com.google.maps.android.compose

import java.util.Objects

internal val DefaultMapUiSettings = MapUiSettings()
/**
* Default settings are all enabled.
*/
public val DefaultMapUiSettings: MapUiSettings = MapUiSettings()

/**
* Data class for UI-related settings on the map.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ internal class MapPropertiesNode(
}
}

internal val NoPadding = PaddingValues()
/**
* Default map content padding does not pad.
*/
public val DefaultMapContentPadding: PaddingValues = PaddingValues()

/**
* Used to keep the primary map properties up to date. This should never leave the map composition.
Expand All @@ -97,7 +100,7 @@ internal inline fun MapUpdater(
mergeDescendants: Boolean = false,
contentDescription: String?,
cameraPositionState: CameraPositionState,
contentPadding: PaddingValues = NoPadding,
contentPadding: PaddingValues = DefaultMapContentPadding,
locationSource: LocationSource?,
mapProperties: MapProperties,
mapUiSettings: MapUiSettings,
Expand Down

0 comments on commit 0a03820

Please sign in to comment.