Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve MarkerState API #515

Merged
merged 6 commits into from
Jun 6, 2024

Commits on May 27, 2024

  1. fix: improve MarkerState API

    This is a non-breaking change following suggestions from @arriolac for addressing googlemaps#149: googlemaps#150 (comment)
    
    This PR does not add an `onDrag` callback parameter to `Marker()`, which would be a somewhat breaking change; this functionality is not strictly necessary and I see alternatives that may be preferable.
    
    Summary of changes:
    
    1. Deprecate MarkerState.dragState and DragState enum. These were carried over from GoogleMap SDK; they are events that were mischaracterized as states.
    2. Replace with MarkerState.isDragging boolean.
    3. Clarify KDoc in several places.
    4. Add several examples providing patterns for common use cases.
    5. Organize Marker-related examples into their own folder.
    
    Fixes googlemaps#149
    bubenheimer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    97fcfa4 View commit details
    Browse the repository at this point in the history
  2. Add an example for how to efficiently create a derived list of Marker…

    …States from a changing model list of marker positions by collecting results from key() composable
    
    Rename marker examples folder to markerexamples for clarity
    bubenheimer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0d3ae1f View commit details
    Browse the repository at this point in the history
  3. Refine example

    bubenheimer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    7e4d48c View commit details
    Browse the repository at this point in the history
  4. Improve KDoc for example

    bubenheimer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    04342cf View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Improve KDoc for example

    bubenheimer committed May 29, 2024
    Configuration menu
    Copy the full SHA
    765c6fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb673f9 View commit details
    Browse the repository at this point in the history