Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change GoogleMap() content parameter default to {} and make content non-nullable #521

Merged
merged 1 commit into from
May 7, 2024
Merged

feat!: change GoogleMap() content parameter default to {} and make content non-nullable #521

merged 1 commit into from
May 7, 2024

Conversation

bubenheimer
Copy link
Contributor

@bubenheimer bubenheimer commented Feb 1, 2024 •
edited by kikoso

Fixes #493

kikoso
kikoso approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged for one of the upcoming versions. Since it is a breaking change, we should evaluate if it needs to be packed together with other breaking PRs.

@kikoso kikoso mentioned this pull request May 6, 2024
Merged
4 tasks
@kikoso kikoso changed the title feat!: change GoogleMap() content parameter default to {} and make co… feat!: change GoogleMap() content parameter default to {} and make content non-nullable May 7, 2024
@kikoso kikoso changed the title feat!: change GoogleMap() content parameter default to {} and make content non-nullable feat: change GoogleMap() content parameter default to {} and make content non-nullable May 7, 2024
@kikoso kikoso changed the title feat: change GoogleMap() content parameter default to {} and make content non-nullable feat!: change GoogleMap() content parameter default to {} and make content non-nullable May 7, 2024
@dkhawk dkhawk merged commit 8e5e3a6 into googlemaps:main May 7, 2024
5 checks passed
googlemaps-bot pushed a commit that referenced this pull request May 7, 2024
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
0ee870d 
# [5.0.0](v4.4.2...v5.0.0) (2024-05-07)

### Bug Fixes

* fixed documentation ([#567](#567)) ([31960a2](31960a2))

### Features

* change GoogleMap() content parameter default to {} and make content non-nullable ([#521](#521)) ([8e5e3a6](8e5e3a6)), closes [#493](#493)

### BREAKING CHANGES

* Adds optional contentDescriptor parameter to MarkerComposable and AdvancedMarker.  Makes content parameter of GoogleMap non-nullable, but with an empty default value.
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bubenheimer bubenheimer deleted the change_content_default branch May 7, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhawk dkhawk dkhawk approved these changes

@kikoso kikoso kikoso approved these changes

Assignees

@wangela wangela

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change GoogleMap() content parameter default to {} and make content non-nullable
5 participants
@bubenheimer @googlemaps-bot @dkhawk @kikoso @wangela