-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixed documentation #567
Conversation
## [4.4.3](v4.4.2...v4.4.3) (2024-05-07) ### Bug Fixes * fixed documentation ([#567](#567)) ([31960a2](31960a2))
🎉 This PR is included in version 4.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [5.0.0](v4.4.2...v5.0.0) (2024-05-07) ### Bug Fixes * fixed documentation ([#567](#567)) ([31960a2](31960a2)) ### Features * change GoogleMap() content parameter default to {} and make content non-nullable ([#521](#521)) ([8e5e3a6](8e5e3a6)), closes [#493](#493) ### BREAKING CHANGES * Adds optional contentDescriptor parameter to MarkerComposable and AdvancedMarker. Makes content parameter of GoogleMap non-nullable, but with an empty default value.
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the documentation regressions remain unfixed
@@ -135,7 +135,7 @@ public fun rememberMarkerState( | |||
* A composable for a marker on the map. | |||
* @param state the [MarkerState] to be used to control or observe the marker | |||
* @param contentDescription the content description for accessibility purposes | |||
* @param state such as its position and info window | |||
* state such as its position and info window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fixed
@@ -607,7 +607,7 @@ public fun AdvancedMarker( | |||
* | |||
* @param state the [MarkerState] to be used to control or observe the marker | |||
* @param contentDescription the content description for accessibility purposes | |||
* @param state such as its position and info window | |||
* state such as its position and info window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fixed
@@ -534,7 +534,7 @@ private fun MarkerImpl( | |||
* | |||
* @param state the [MarkerState] to be used to control or observe the marker | |||
* @param contentDescription the content description for accessibility purposes | |||
* @param state such as its position and info window | |||
* state such as its position and info window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fixed
Fixed documentation broke in 450d842