feat: Support specifying animation duration for camera changes.

[arriolac]

Fixes #79 🦕

[barbeau]

Thanks @arriolac! Some comments in-line.

[barbeau]

I typically prefer values like MIN_VALUE or MAX_VALUE over null when overloading a variable with other semantics (like the "default" behavior here) to keep it from being nullable if nullability isn't otherwise required. Although I don't think I've seen any official best practices for this on Kotlin so other points of view are welcome.

I assume you're not overloading animate() to keep the implementation simpler?

[arriolac]

Yes, ideally a constant value would be nice for durationMs but by default the SDK has different durations based on the value of update. And yes, I went with this implementation to keep things simple :)

[barbeau]

Just to clarify, I was thinking of something like this to avoid the nullable ? and use MAX_VALUE as the "default" flag instead of null:

    suspend fun animate(update: CameraUpdate, durationMs: Int = MAX_VALUE) {
    ...
        if (durationMs == MAX_VALUE) {
            map.animateCamera(update, cancelableCallback)
        } else {
            map.animateCamera(update, durationMs, cancelableCallback)
        }

[arriolac]

Gotcha—I do like that better. I integrated your feedback in 3f8c1d6

[barbeau]

This no longer needs to be nullable, right?

[arriolac]

Yep, the conditional should also check for MAX_VALUE 😓 Done in 3f85be9

[barbeau]

LGTM!

[googlemaps-bot]

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

• v2.1.0
• GitHub release

Your semantic-release bot 📦🚀