Fix dark text appearance in TextIconGenerator #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,4 +2,5 @@ | |||
|
|
|||
| * Chris Broadfoot, https://github.com/broady | |||
| * Maciej Gorski, https://github.com/mg6maciej | |||
| * Cyril Mottier, https://github.com/cyrilmottier | |||
There was a problem hiding this comment.
Just noticed, I can't determine what the ordering is based on: first name or last name? I used the last name because that's what we usually do in France but feel free to tell me if it's the first name.
broady
added a commit
that referenced
this pull request
Sep 15, 2013
Fix dark text appearance in TextIconGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource identifier was previously pointing to a drawable rather than a style. Probably one of these (so frequent) copy/paste mistakes :-).