-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Simulator on ARM Macs #428
Conversation
@wangela Could you have a look at this PR? Having Simulator support on ARM Macs would make life easier for a lot of developers. |
This is failing unit tests; I think the tests need to be fixed (rather than the code in this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangela I made pod lint
successfully pass (at least for me locally) by increasing the minimum GoogleMaps version needed.
People requiring support for older versions of iOS will have to rely on older versions of Google-Maps-iOS-Utils, but seeing the pace of new features added to Google-Maps-iOS-Utils, it think it should not be a problem.
The CI was failing on the sample apps so I updated those. Could you please let the CI run once again? |
Now the CI checks all properly pass 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this passing!
Thanks for reviewing! Just changed the version requirement as asked 😄 |
@wangela is it possible to get a new release that includes this change? |
Would love to see this change in a release so I no longer have to use a fork. 😃 |
# [4.2.0](v4.1.0...v4.2.0) (2023-06-02) ### Features * Support Simulator on ARM Macs ([#428](#428)) ([637954e](637954e))
…utils * 'main' of https://github.com/googlemaps/google-maps-ios-utils: chore: update workflows (googlemaps#455) chore(release): 4.2.2 [skip ci] fix: release config (googlemaps#449) chore(release): 4.2.1 [skip ci] fix: re-release with XCFramework and improve README (googlemaps#447) docs: revert unintentionally updated version numbers in Carthage docs (googlemaps#446) chore: semantic release dependencies (googlemaps#443) chore(release): 4.2.0 [skip ci] chore: fix workflows (googlemaps#440) chore: update release.yml (googlemaps#436) chore: Synced local '.github/workflows/dependabot.yml' with remote '.github/workflows/dependabot.yml' (googlemaps#438) feat: Support Simulator on ARM Macs (googlemaps#428) # Conflicts: # Package.swift
Fixes #391
Google Maps 7.3.0's CocoaPods version now uses XCFramework, so Google-Maps-iOS-Utils should not use
EXCLUDED_ARCHS
anymore.