Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Simulator on ARM Macs #428

Merged
merged 4 commits into from
Feb 22, 2023
Merged

feat: Support Simulator on ARM Macs #428

merged 4 commits into from
Feb 22, 2023

Conversation

vincentisambart
Copy link
Contributor

Fixes #391

Google Maps 7.3.0's CocoaPods version now uses XCFramework, so Google-Maps-iOS-Utils should not use EXCLUDED_ARCHS anymore.

@vincentisambart
Copy link
Contributor Author

@wangela Could you have a look at this PR? Having Simulator support on ARM Macs would make life easier for a lot of developers.

@wangela wangela changed the title Support Simulator on ARM Macs feat: Support Simulator on ARM Macs Feb 9, 2023
@wangela
Copy link
Member

wangela commented Feb 9, 2023

This is failing unit tests; I think the tests need to be fixed (rather than the code in this PR).

vincentisambart
vincentisambart commented Feb 10, 2023
View reviewed changes
Copy link
Contributor Author

@vincentisambart vincentisambart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangela I made pod lint successfully pass (at least for me locally) by increasing the minimum GoogleMaps version needed.
People requiring support for older versions of iOS will have to rely on older versions of Google-Maps-iOS-Utils, but seeing the pace of new features added to Google-Maps-iOS-Utils, it think it should not be a problem.

Google-Maps-iOS-Utils.podspec Show resolved Hide resolved
Google-Maps-iOS-Utils.podspec Outdated Show resolved Hide resolved
@aleqsio aleqsio mentioned this pull request Feb 16, 2023
Merged
3 tasks
@vincentisambart
Copy link
Contributor Author

The CI was failing on the sample apps so I updated those. Could you please let the CI run once again?

@vincentisambart
Copy link
Contributor Author

Now the CI checks all properly pass 😁

wangela
wangela requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this passing!

Google-Maps-iOS-Utils.podspec Outdated Show resolved Hide resolved
samples/SwiftDemoApp/Podfile Outdated Show resolved Hide resolved
samples/ObjCDemoApp/Podfile Outdated Show resolved Hide resolved
@vincentisambart
Copy link
Contributor Author

Thanks for reviewing! Just changed the version requirement as asked 😄

@wangela wangela merged commit 637954e into googlemaps:main Feb 22, 2023
@vincentisambart vincentisambart deleted the arm-mac-simulator branch February 23, 2023 01:37
@zaubara zaubara mentioned this pull request Mar 1, 2023
Closed
@brushton-ces
Copy link

@wangela is it possible to get a new release that includes this change?

@sdornan
Copy link

sdornan commented Mar 23, 2023

Would love to see this change in a release so I no longer have to use a fork. 😃

@aserdobintsev aserdobintsev mentioned this pull request Mar 29, 2023
Closed
googlemaps-bot pushed a commit that referenced this pull request Jun 2, 2023
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
d0a299c 
# [4.2.0](v4.1.0...v4.2.0) (2023-06-02)

### Features

* Support Simulator on ARM Macs ([#428](#428)) ([637954e](637954e))
ArshAulakh59 pushed a commit to ArshAulakh59/google-maps-ios-utils that referenced this pull request Apr 27, 2024
@ArshUpgame
Merge branch 'main' of https://github.com/googlemaps/google-maps-ios-…
2792daf 
…utils

* 'main' of https://github.com/googlemaps/google-maps-ios-utils:
  chore: update workflows (googlemaps#455)
  chore(release): 4.2.2 [skip ci]
  fix: release config (googlemaps#449)
  chore(release): 4.2.1 [skip ci]
  fix: re-release with XCFramework and improve README (googlemaps#447)
  docs: revert unintentionally updated version numbers in Carthage docs (googlemaps#446)
  chore: semantic release dependencies (googlemaps#443)
  chore(release): 4.2.0 [skip ci]
  chore: fix workflows (googlemaps#440)
  chore: update release.yml (googlemaps#436)
  chore: Synced local '.github/workflows/dependabot.yml' with remote '.github/workflows/dependabot.yml' (googlemaps#438)
  feat: Support Simulator on ARM Macs (googlemaps#428)

# Conflicts:
#	Package.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podspec: invalid EXCLUDE_ARCHS value
4 participants
@vincentisambart @wangela @brushton-ces @sdornan