-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for google maps sdk v8 #451
base: main
Are you sure you want to change the base?
Conversation
This looks great! @wangela, any chance this could be merged soon? |
Thanks for offering this PR, @Simon-TechForm! Would you be able to patch into #444 instead of this separate PR? There are a number of changes in that PR that raise the minimum OS appropriately to match the requirements of 8.0. When you do that, to follow the best practice of specifying an exact version number when depending on the Maps SDK for iOS, let's specify exactly 8.0.0. If you'd rather not patch, I don't mind doing the change myself but I want to make sure you have the opportunity to have your contribution counted in the main branch. |
@monholm are you able to patch into #444 ?
|
@wangela can you please simply merge this ? it's blocking adding support for Google-Maps above 7.2 to react-native-maps |
@wangela is there any plan to merge this eventually ? |
@wangela Hi, does this PR have a merger plan? The progress is completely lagging behind. |
Any plans merging this? |
Google Maps SDK for iOS v8.0.0 was released with no other breaking changes than freezing support for iOS 13, meaning it should be safe to support it in Google Maps iOS Utils. See v8 release notes.
I did some brief testing and experienced no issues while using Google Maps SDK for iOS v8.0.0.