New Feature: Support for Google Map Config (mapId, liteMode) #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2023 15:47
- Android: LiteMode and mapID as InitProps - Android: remove unnecessary module for MapLite - Examples: LiteMode working with initialProps formatting: whitespace cleanup
- iOS: code works to pass mapID to googleMaps - iOS: swizzling RCTComponentData to add support for initialProps - iOS: Any RCTViewManager will automatically have initialProps autofilled if property is available
- remove unused import from MapView
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🤦 still waiting on googlemaps/google-maps-ios-utils#451 to be merged for iOS support |
|
Hi, It's operational or not yet ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
Google Maps introduced a new styling capability via google cloud, this library didn't support any kind of initialisation on view creation before, and depended even on creating a custom module just to pass an initial property for Android: liteMode
This is now fixed and initial properties can be passed
supported properties: googleMapId (iOS, Android) , liteMode (Android only)
How did you test this PR?
Physically on android and iOS devices, the values are being setup correctly.
Unfortunately for iOS without updating to google-maps SDK v 8.2 the style won't be visible .. waiting on google