Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PendingResult#await throw specific Exception #238

Merged
merged 6 commits into from
Mar 22, 2017
Merged

Make PendingResult#await throw specific Exception #238

merged 6 commits into from
Mar 22, 2017

Commits on Mar 10, 2017

  1. Explicitly throw exception when unexpected (non GET or POST) request … 

    …verb is specified.

Before this change, such request ended up NullPointerExceptions.
    Kazuki Nishiura committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    a739b8e View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2017

  1. Refactor GaePendingResult so await method throws specific Exception c… 

    …lasses, not generic Exception
    Kazuki Nishiura committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    de35600 View commit details
    Browse the repository at this point in the history

  2. Update UrlSigner to fail fast. Initialize MAC instance within constru… 

    …ctor

so exception is thrown if invalid key is passed or provider for
HMAC-SHA1 doesn't exist
    Kazuki Nishiura committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    53951df View commit details
    Browse the repository at this point in the history

  3. Add comment around never-happening UnsupportedEncodingException for U… 

    …TF-8

According to following doc, UTF-8 support is required for
every Java implementation.
http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html
    Kazuki Nishiura committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    b5575ee View commit details
    Browse the repository at this point in the history

  4. Remove unused ExceptionResult

    Kazuki Nishiura committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    fa50c98 View commit details
    Browse the repository at this point in the history

  5. Refactor PendingResult and OkHttpPendingResult to throw specific exce… 

    …ptions,

rather than generic Exception.
    Kazuki Nishiura committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    f59118e View commit details
    Browse the repository at this point in the history