Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding proxy authentication in GeoApiContext #337

Merged
merged 2 commits into from
Aug 22, 2017

Conversation

lhomme-a
Copy link
Contributor

its a pull request for issue #336 proxy authentication in GeoApiContext
it can close also the reopened issue #141

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@lhomme-a
Copy link
Contributor Author

lhomme-a commented Aug 17, 2017 via email

@googlebot
Copy link

CLAs look good, thanks!

@domesticmouse
Copy link
Contributor

Is there a way of adding some form of test over this additional functionality?

@domesticmouse
Copy link
Contributor

Also, please run ./gradlew googleJavaFormat to format your java code to the Google java formatting rules. Thanks!

@lhomme-a
Copy link
Contributor Author

lhomme-a commented Aug 21, 2017 via email

@domesticmouse
Copy link
Contributor

Sounds good to me, thank you for your PR!

@domesticmouse domesticmouse merged commit eeb7af1 into googlemaps:master Aug 22, 2017
@Falydoor
Copy link

Falydoor commented Sep 7, 2017

Any idea when this feature will be pushed to maven (with version 0.2.3 I guess) ?

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants