Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example of promise constructor #103

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Added example of promise constructor #103

merged 1 commit into from
Jul 11, 2017

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 11, 2017

Addresses #99

I opted not to use ES6 shorthand here, as I think it's nicer to make clear that the property name is 'Promise'.

If it's not clear enough, I'm happy to also add an example of using Bluebird or another Promise library.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@G-Rath
Copy link
Contributor Author

G-Rath commented Jul 11, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@stephenmcd
Copy link
Contributor

That's great, thanks a lot!

@stephenmcd stephenmcd merged commit af35a0a into googlemaps:master Jul 11, 2017
@G-Rath G-Rath deleted the add-promise-constructor-example branch July 11, 2017 23:32
@0xpatrickdev
Copy link

0xpatrickdev commented Jul 27, 2017

Hey @G-Rath, this is great.

@stephenmcd I'm not sure how you manage the source/build for the gh-pages site, but it would be helpful to have this example on there too. I can create a PR on the gh-pages branch if that's where you manage it.

@stephenmcd
Copy link
Contributor

@pcooney10 I've just updated the docs site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants