Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup Removes Trailing Region Tag Comment #84

Closed
jpoehnelt opened this issue Nov 25, 2019 · 1 comment · Fixed by #88
Closed

Rollup Removes Trailing Region Tag Comment #84

jpoehnelt opened this issue Nov 25, 2019 · 1 comment · Fixed by #88
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. released

Comments

@jpoehnelt
Copy link
Contributor

jpoehnelt commented Nov 25, 2019

Babel moving the region tag comment after a closing bracket causes invalid JavaScript when combined with the includecode widget.

// [START foo_definition]
function  foo() {
}
// [END foo_definition]

becomes

// [START foo_definition]
function  foo() {
} // [END foo_definition]

This is an issue because these comments trigger the entire line to be removed from the documentation page such that it becomes

function  foo() {

Two Options:

  1. have babel strip these comments?
  2. pass a regex to includecode that allows the entire line to remain?
@jpoehnelt jpoehnelt added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Nov 25, 2019
@jpoehnelt jpoehnelt self-assigned this Nov 25, 2019
@jpoehnelt jpoehnelt changed the title Babel Moves Region Tag Comment Rollup Removes Trailing Region Tag Comment Nov 26, 2019
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. released
Projects
None yet
2 participants