Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed android.app.Fragment callbacks from rationale dialog #61

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

phcannesson
Copy link
Contributor

Fix for issue #57.

I'm not 100% happy with the fix because it will only work on API > 17.

But do we really care about API < 17 as the permissions check at runtime appeared on Android Marshmallow?
In any case, we do the same API version check on file RationaleDialogFragment, so it would also need to be fixed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@phcannesson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@phcannesson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@samtstern
Copy link
Contributor

@phcannesson this change LGTM, thank you!

As for whether we care about API<17: No, not really. I think a larger refactor of this library is needed to make all the operations no-ops on API less than Marshmallow, since there are too many API and class checks all over the place. It's just technical debt that's accumulated, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants