Fixed crash on rationale click listener when using android.app.Fragment #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phcannesson can you reproduce this crash in version |
|
Yes I reproduced it when upgrading to 0.3.0. mHost is android.app.Fragment and therefore the app crashes when trying to cast it as FragmentActivity. |
|
@phcannesson oh I see now, I mixed up Fragment and FragmentActivity in my head. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR #61 introduced a crash in RationaleDialogClickListener when trying to cast Fragment host as FragmentActivity.
I did not have the time to fully test it but it should be the only regression.