Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy S7 | iPhone 7 | DPDB : In general how to compute? #164

Closed
devasur opened this issue Oct 14, 2016 · 4 comments
Closed

Galaxy S7 | iPhone 7 | DPDB : In general how to compute? #164

devasur opened this issue Oct 14, 2016 · 4 comments

Comments

@devasur
Copy link

devasur commented Oct 14, 2016

Can someone please explain how to compute DBDB JSON entry for a new device.
Taking values from http://btco-code.appspot.com/debug/screen_test.html as a starting point?

@PixelPartner
Copy link

Maybe @btco could help out, as also the new Google Pixel models are missing.
The iPhone7 and Plus model should be detected like the iPhone6/6S [Plus] models, but also those have weird stereo effects.
Meanwhile I'll try to fix it locally.

@PixelPartner
Copy link

You may try those entries in dpdb-cache.js and not load the JSON from google.

  { /* Galaxy S7 */
    "type": "android",
    "rules": [
      { "mdmh": "samsung/*/SM-G930F/*" },
      { "ua": "SM-G930F" }
    ],
    "dpi": 576.6,
    "bw": 3,
    "ac": 1000
  },

  { /* Galaxy S7 edge plus*/
    "type": "android",
    "rules": [
      { "mdmh": "samsung/*/SM-G935F/*" },
      { "ua": "SM-G935F" }
    ],
    "dpi": 534,
    "bw": 3,
    "ac": 1000
  },


@jsantell
Copy link
Contributor

In #233, the local DPDB has been updated and sync'd with the online version at webvr.rocks (once immersive-web/webvr-polyfill-dpdb#7 is merged), including the SM-G930F and SM-G935F phones. Try the latest version which should fix this -- please reopen if this does not fix the issue.

Also for finding DPDB values, check out this link immersive-web/webvr-polyfill-dpdb#9 which should help.

Thanks!

@cvan
Copy link
Contributor

cvan commented May 24, 2017

Now at https://github.com/WebVRRocks/webvr-polyfill-dpdb#adding-a-device - thanks, @jsantell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants