0.10.0 #298
Merged
0.10.0 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency. No longer rely on global WebVRConfig and instantiate as traditional constructor.
…ructor now, and no longer bake utility function results in closures as they're called only once/twice during initialization, and this makes testing easier
…on commands, modernize workflow
lincolnfrog
approved these changes
Dec 14, 2017
test/init.js
Outdated
| // Logic similar to https://github.com/webmodules/custom-event | ||
| // but can't rely on it's feature detection due to timing | ||
| // of including the shim and populating window/document | ||
| global.CustomEvent = function CustomEvent (type, params) { |
There was a problem hiding this comment.
Also, why not use (type, params) => {
Seems clearer...
There was a problem hiding this comment.
lint fixed, and this is a constructor to simulate the global in cardboard-vr-display (which relies on globals unfortunately) as these run in a node environment
test/webvr-polyfill.test.js
Outdated
| }); | ||
|
|
||
| describe('hasNative', () => { | ||
| it('false when no native support found', () => { |
There was a problem hiding this comment.
standard it string would be 'should be false when no native support found'. Same for below (add 'should be')
…ee.js source code, fix #297 with global.document clobbering, and fix typo in webvr-polyfill.js
jsantell
force-pushed
the
cardboard-vr-display
branch
from
a60492c
to
65c6298
Compare
This was referenced Dec 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been working on these changes for a bit now, quite a big overhaul! Wanted to put up a PR to get comments and concerns from the WebVR community before landing. Changes and rationale from the release notes draft as follows:
v0.10.0
This is one of the largest updates for the Polyfill in quite some time! Most changes are refactoring, focusing on pulling pieces out to make it easier to scope, test, and work on future changes as the WebXR Device API approaches, so we can be more confident in changes without breaking edge cases. The polyfill was also scope creeping a bit, doing more than just providing a stable API surface for developers to target, and many of these features have been removed that are better off in userland and on a per-project basis.
Feature Changes
new window.WebVRPolyfill(options). Previously this was handled by defining options on a globalwindow.WebVRConfigobject, and the polyfill would instantiate itself immediately, or require the user to callwindow.InitializeWebVRPolyfill()ifDEFER_INITIALIZATIONwas set.DEFER_INITIALIZATIONhas been removed, the polyfill no longer instantiates itself, and options are passed into the constructor rather than relying on a global object. This makes it easier to work with in module environments and other JS build systems.InstallWebVRSpecShim()has been removed.navigator.vrEnabledproperty has been removed. This was used to indicate if displays exist, which can be done by checking the return value ofgetVRDisplays().MouseKeyboardVRDisplayhas been removed. This provided a monoview VRDisplay with some primitive controls for a 3DOF experience. This is better handled with custom controls or OrbitControls depending on the experience.MOUSE_KEYBOARD_CONTROLS_DISABLEDoption has been removed. This means on desktop, the only displays that can exist are native, so user code should handle when no displays are found.MouseKeyboardVRDisplay, and the WebXR Device API only allowing one display rather than an array of displays,ALWAYS_APPEND_POLYFILL_DISPLAYhas been removed. A new option,PROVIDE_MOBILE_VRDISPLAYhas been created to provide aCardboardVRDisplaywhen on mobile and the native API exists but no native displays exists.trueby default, this means that the polyfill is always injected on mobile when enabled, since we won't know immediately if any native displays exist.FORCE_ENABLE_VRhas been removed. This always provided aCardboardVRDisplay, even on desktop, used mostly for debugging purposes.DEBUGoption. Previously this was triggered by a?debugquery parameter, which caused issues with other environments.mainpackage.json entry now points to the built output rather thansrc/node-entry. This lets us take advantage of our build system and not require consumers to handle any transformations implemented.WebVRPolyfillmethods and properties have been removed:isFullScreenAvailable,isCardboardCompatible,isMobile,NativeVRFrameData,getVRDevices,enableDeprecatedPolyfill,isDeprecatedWebVRAvailable,isWebVRAvailable.Infrastructure Changes