Rework examples to use 0.10.0 polyfill #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an issue with responding correctly to polyfilled vrdisplaypresentchange events, since the
display
property lives on aevent.detail
object due to CustomEvent restrictions. Tested on desktop and mobile with no API support, and on mobile with daydream support.This is dependent on landing immersive-web/webvr-polyfill#298, but wanted to get this out for any changes needed before then.
functionality changes:
test-
samples hadPOLYFILL_MODE = 'always'
, which hasn't been an option in the polyfill for as long as I remember, so this currently isn't an option in the polyfill (can discuss adding it!), but the API will no longer always be clobbered. FWIW, the previous version of the polyfill in this repo didn't have the option implemented anyway, so no change 😄