Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework examples to use 0.10.0 polyfill #85

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Dec 14, 2017

Also fixes an issue with responding correctly to polyfilled vrdisplaypresentchange events, since the display property lives on a event.detail object due to CustomEvent restrictions. Tested on desktop and mobile with no API support, and on mobile with daydream support.

This is dependent on landing immersive-web/webvr-polyfill#298, but wanted to get this out for any changes needed before then.

functionality changes:

  • due to the removal of the desktop VRDisplay, accessing these samples on a non-supported desktop correctly gives the "WebVR found but no display" messages.
  • The test- samples had POLYFILL_MODE = 'always', which hasn't been an option in the polyfill for as long as I remember, so this currently isn't an option in the polyfill (can discuss adding it!), but the API will no longer always be clobbered. FWIW, the previous version of the polyfill in this repo didn't have the option implemented anyway, so no change 😄
  • BUFFER_SCALE set to 0.75 in some demos. Sometime last year the default was reduced from 1.0 to 0.5. Just a note, not sure if this is necessary now with the lower default (and if the other samples should use 1.0)

@jsantell
Copy link
Contributor Author

Just landed 0.10.0 changes FYI

@toji toji merged commit 549023e into toji:master Dec 20, 2017
@toji
Copy link
Owner

toji commented Dec 20, 2017

LGTM, thanks! I'm a fan of the newer syntax, BTW.

@jsantell
Copy link
Contributor Author

Same! Smoothing out the path to WebXR Device API polyfill 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants