fix: app help not working on input -h|--help

gookit · Jul 18, 2022 · 0231311 · 0231311
1 parent f1b474e
commit 0231311
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app.go b/app.go
@@ -265,7 +265,7 @@ func (app *App) AddAliases(name string, aliases ...string) {
 
 // parseGlobalOpts parse global options
 func (app *App) parseGlobalOpts(args []string) (ok bool) {
-	Logf(VerbDebug, "will begin parse global options")
+	Logf(VerbDebug, "will begin parse application options")
 
 	// parse global options
 	err := app.core.doParseGOpts(args)

diff --git a/base.go b/base.go
@@ -10,6 +10,7 @@ import (
 	"strings"
 
 	"github.com/gookit/color"
+	"github.com/gookit/goutil/cflag"
 	"github.com/gookit/goutil/mathutil"
 	"github.com/gookit/goutil/structs"
 	"github.com/gookit/goutil/strutil"
@@ -43,17 +44,20 @@ type core struct {
 // 	})
 // }
 
+// parse global options
 func (c core) doParseGOpts(args []string) (err error) {
 	if c.gFlags == nil { // skip on nil
 		return
 	}
 
-	// parse global options
 	err = c.gFlags.Parse(args)
+
 	if err != nil {
+		if cflag.IsFlagHelpErr(err) {
+			return nil
+		}
 		Logf(VerbWarn, "parse global options err: <red>%s</>", err.Error())
 	}
-
 	return
 }