fix: handling of CmdNotFound errors

gookit · Aug 8, 2022 · 0c89eea · 0c89eea
1 parent bfdd98d
commit 0c89eea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/app.go b/app.go
@@ -336,12 +336,15 @@ func (app *App) prepareRun() (code int, name string) {
 	if app.inputName == "" {
 		Logf(VerbDebug, "input the command is not an registered: %s", name)
 
-		if stop := app.Fire(EvtAppCmdNotFound, name); stop == false {
-			stop = app.Fire(EvtCmdNotFound, name)
-			if stop == false {
-				app.showCommandTips(name)
-			}
+		// fire events
+		if stop := app.Fire(EvtAppCmdNotFound, name); stop {
+			return
+		}
+		if stop := app.Fire(EvtCmdNotFound, name); stop {
+			return
 		}
+
+		app.showCommandTips(name)
 		return
 	}
 

diff --git a/cmd.go b/cmd.go
@@ -454,12 +454,10 @@ func (c *Command) innerDispatch(args []string) (err error) {
 			// no arguments, name is not founded subcommand
 			if !c.HasArguments() {
 				// fire events
-				stop := c.Fire(EvtCmdSubNotFound, name)
-				if stop == true {
+				if stop := c.Fire(EvtCmdSubNotFound, name); stop {
 					return
 				}
-
-				if stop = c.Fire(EvtCmdNotFound, name); stop == false {
+				if stop := c.Fire(EvtCmdNotFound, name); stop {
 					return
 				}