up: fix cmd init error, missing init cli parser

gookit · Oct 3, 2022 · 4c7ed4b · 4c7ed4b
1 parent 3482598
commit 4c7ed4b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -31,7 +31,7 @@ jobs:
         go-version: ${{ matrix.go_version }}
 
     - name: Revive check
-      uses: morphy2k/revive-action@v2.4.0
+      uses: morphy2k/revive-action@v2.4.1
       if: ${{ matrix.os == 'ubuntu-latest' }}
       with:
         # Exclude patterns, separated by semicolons (optional)

diff --git a/cmd.go b/cmd.go
@@ -262,11 +262,8 @@ func (c *Command) initialize() {
 		}
 	}
 
-	// init for cmd Arguments
-	c.Flags.SetName(cName)
-
-	// init for cmd flags
-	c.InitFlagSet(cName)
+	// init for cmd flags parser
+	c.InitParser(cName)
 
 	// format description
 	if len(c.Desc) > 0 {

diff --git a/gflag/opts.go b/gflag/opts.go
@@ -44,10 +44,6 @@ func (ops *CliOpts) InitFlagSet(name string) {
 		return
 	}
 
-	// if ops.cfg == nil {
-	// 	ops.cfg = newDefaultFlagConfig()
-	// }
-
 	ops.name = name
 	ops.fSet = flag.NewFlagSet(name, flag.ContinueOnError)
 	// disable output internal error message on parse flags

diff --git a/gflag/parser.go b/gflag/parser.go
@@ -74,6 +74,19 @@ func New(nameWithDesc ...string) *Parser {
 	return p
 }
 
+// InitParser for parser
+func (p *Parser) InitParser(name string) {
+	if p.out == nil {
+		p.out = os.Stdout
+	}
+	if p.cfg == nil {
+		p.cfg = newDefaultFlagConfig()
+	}
+
+	p.SetName(name)
+	p.InitFlagSet(name)
+}
+
 // SetName for parser
 func (p *Parser) SetName(name string) {
 	p.name = name