Skip to content

Commit

Permalink
💡 chore: add exported var comment, fix some name style
Browse files Browse the repository at this point in the history
  • Loading branch information
inhere committed Dec 10, 2022
1 parent 6ace647 commit ea10bc7
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion fmtutil/format.go
Expand Up @@ -53,7 +53,7 @@ func ParseByte(sizeStr string) uint64 {
// last second char is k,m,g
lastSec := sizeStr[lastPos-1]
if lastSec > 'A' {
lastPos -= 1
lastPos--
}
}

Expand Down
4 changes: 2 additions & 2 deletions maputil/convert.go
Expand Up @@ -29,8 +29,8 @@ func ToStringMap(src map[string]any) map[string]string {
return newMp
}

// HttpQueryString convert map[string]any data to http query string.
func HttpQueryString(data map[string]any) string {
// HTTPQueryString convert map[string]any data to http query string.
func HTTPQueryString(data map[string]any) string {
ss := make([]string, 0, len(data))
for k, v := range data {
ss = append(ss, k+"="+strutil.QuietString(v))
Expand Down
4 changes: 2 additions & 2 deletions maputil/convert_test.go
Expand Up @@ -25,9 +25,9 @@ func TestToStringMap(t *testing.T) {
assert.Eq(t, ret["b"], "23")
}

func TestHttpQueryString(t *testing.T) {
func TestHTTPQueryString(t *testing.T) {
src := map[string]any{"a": "v0", "b": 23}
str := maputil.HttpQueryString(src)
str := maputil.HTTPQueryString(src)

fmt.Println(str)
assert.Contains(t, str, "b=23")
Expand Down
2 changes: 2 additions & 0 deletions maputil/data.go
Expand Up @@ -9,6 +9,8 @@ import (

// Data an map data type
type Data map[string]any

// Map alias of Data
type Map = Data

// Has value on the data map
Expand Down
5 changes: 4 additions & 1 deletion strutil/textscan/parser.go
Expand Up @@ -16,6 +16,7 @@ type Parser struct {
Func HandleFn
}

// NewParser instance
func NewParser(fn HandleFn) *Parser {
return &Parser{
Func: fn,
Expand All @@ -28,20 +29,22 @@ func (p *Parser) AddMatchers(ms ...Matcher) {
p.ts.AddMatchers(ms...)
}

// Parse input bytes
func (p *Parser) Parse(bs []byte) error {
return p.ParseFrom(bytes.NewReader(bs))
}

// ParseText input string
func (p *Parser) ParseText(text string) error {
return p.ParseFrom(strings.NewReader(text))
}

// ParseFrom input reader
func (p *Parser) ParseFrom(r io.Reader) error {
ts := NewScanner(r)

for ts.Scan() {
p.Func(ts.Token())
}

return nil
}

0 comments on commit ea10bc7

Please sign in to comment.