up: sys/cmdr - add more methods to Task, update some tests

sysutil/cmdr/cmd.go

@@ -1,6 +1,7 @@
 package cmdr
 
 import (
+	"context"
 	"fmt"
 	"io"
 	"os"
@@ -15,6 +16,7 @@ type Cmd struct {
 	*exec.Cmd
 	// Name of the command
 	Name string
+	// inited bool
 
 	// RunBefore hook
 	RunBefore func(c *Cmd)
@@ -28,12 +30,29 @@ func WrapGoCmd(cmd *exec.Cmd) *Cmd {
 }
 
 // NewCmd instance
+//
+// see exec.Command
 func NewCmd(bin string, args ...string) *Cmd {
 	return &Cmd{
+		// inited: true,
 		Cmd: exec.Command(bin, args...),
 	}
 }
 
+// CmdWithCtx create new instance with context.
+//
+// see exec.CommandContext
+func CmdWithCtx(ctx context.Context, bin string, args ...string) *Cmd {
+	return &Cmd{
+		// inited: true,
+		Cmd: exec.CommandContext(ctx, bin, args...),
+	}
+}
+
+// -------------------------------------------------
+// config the command
+// -------------------------------------------------
+
 // OnBefore exec add hook
 func (c *Cmd) OnBefore(fn func(c *Cmd)) *Cmd {
 	c.RunBefore = fn
@@ -68,6 +87,12 @@ func (c *Cmd) lookPath(name string) {
 	}
 }
 
+// WithGoCmd and returns the current instance.
+func (c *Cmd) WithGoCmd(ec *exec.Cmd) *Cmd {
+	c.Cmd = ec
+	return c
+}
+
 // WithWorkDir returns the current object
 func (c *Cmd) WithWorkDir(dir string) *Cmd {
 	c.Dir = dir
@@ -87,7 +112,7 @@ func (c *Cmd) WithStdin(in io.Reader) *Cmd {
 	return c
 }
 
-// WithOutput returns the current argument
+// WithOutput returns the current instance
 func (c *Cmd) WithOutput(out, errOut io.Writer) *Cmd {
 	c.Stdout = out
 	if errOut != nil {

sysutil/cmdr/runner.go

@@ -66,6 +66,11 @@ func (t *Task) Err() error {
 	return t.err
 }
 
+// IsSuccess of task
+func (t *Task) IsSuccess() bool {
+	return t.err == nil
+}
+
 // Runner use for batch run multi task commands
 type Runner struct {
 	prev *Task

sysutil/cmdr/runner_test.go

@@ -22,6 +22,7 @@ func TestRunner_Run(t *testing.T) {
 	task, err := rr.Task("task1")
 	assert.NoErr(t, err)
 	assert.NoErr(t, task.Err())
+	assert.True(t, task.IsSuccess())
 
 	ids := rr.TaskIDs()
 	// dump.P(rr.TaskIDs())