This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Atmos/various states forcefield #59
Closed
Kyle2143
wants to merge
27
commits into
goonstation:goonstation-2016-byond510
from
Kyle2143:atmos-forcefield
Closed
Atmos/various states forcefield #59
Kyle2143
wants to merge
27
commits into
goonstation:goonstation-2016-byond510
from
Kyle2143:atmos-forcefield
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teorshield to energy_shield parent class.
…here, but didn't need to be there.
…st. Does not compile
…ight not be necessary, but I'm not sure how far the range for update_tiles() goes. But at most it will call it only 9 times if the shield is activated
…bered when I was taking a look at making the hangar door shields
ZeWaka
force-pushed
the
goonstation-2016-byond510
branch
2 times, most recently
from
March 6, 2019 07:08
4bb3e79
to
c317986
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new forcefield generator that can create a shield that prevents atmos from passing, and can toggle between preventing liquid(hopefully, I left a spot for it, but since I can't see the liquid code I can't do anything with it), and a solid shield.
It essentially inherits from the Meteor Shield in obj/machinery. I moved most of the code in MeteorShield into a parent shield generator class. Currently the parent class has most of the functionality for meteorclass and methods are overridden where necessary for my new shield. The path for meteorshield has changed, but I didn't include any map changes in this.
I also added a new feature for the meteorshield that is also present in my new sheild. One I've wanted for a while. Now you can wrench a generator without a battery onto a wire, and if there is power, you can run the shield from station equipment power. Also, I changed the MeteorShield power consumption to reflect what was stated in the examine text.