Pug Thralls cannot emote

[goonstation-issuebot]

Labels

[BUG][MINOR]

Description

Thralled pugs cannot emote through keybinds or typing it manually

Steps to reproduce

1. Be pug
2. Get thralled
3. Attempt emoting

Expected Behavior

not this

Additional Information & Screenshots

Reported by: Bomb_Sirens
On server: Goonstation 1 Classic: Heisenbee
Active test merges: #16477 and #16449
Round log date: 2023-10-26-10-49
Reported on: 2023-10-26 12:08:19
Map: COGMAP

[gear-space]

Related to #16561
Same root cause - pugs have a special emote trigger on oxy damage that is triggering when mob is dead

goonstation/code/mob/living/carbon.dm

Lines 182 to 188 in 65bd5ae

	if (ispug(src))
	var/mob/living/carbon/human/H = src
	amount *= 2
	H.emote(pick("wheeze", "cough", "sputter"))
	src.oxyloss = max(0,src.oxyloss + amount)
	return

Guessing that emote_allowed gets set to false/0 as part of doing the oxy damage emote, never gets set back to true/1 since the source is now a new entity after being thralled?

goonstation/code/mob/living/carbon/human/procs/emote.dm

Lines 10 to 11 in 3c573a7

	if(voluntary && !src.emote_allowed)
	return

Also explains why they do a little gasp when revived as a thrall.

###Callstack when thrall comes back
/mob/living/carbon/take_oxygen_deprivation (goonstation\code\mob\living\carbon.dm:185)
/mob/living/carbon/full_heal (goonstation\code\mob\living\carbon.dm:131)
/mob/living/carbon/human/full_heal (goonstation\code\mob\living\carbon\human.dm:2349)
/datum/abilityHolder/vampire/make_thrall (goonstation\code\modules\antagonists\vampire\abilities\_vampire_ability_holder.dm:307)
/datum/action/bar/private/icon/vampire_enthrall_thrall/onEnd (goonstation\code\modules\antagonists\vampire\abilities\enthrall.dm:128)
/datum/action_controller/process (goonstation\code\datums\controllers\action_controls.dm:87)
/datum/controller/process/actions/doWork (goonstation\code\datums\controllers\process\actions.dm:17)
/datum/controller/process/process (goonstation\code\datums\controllers\process\_process.dm:165)
/datum/controller/processScheduler/runProcess (goonstation\code\datums\controllers\process_scheduler.dm:215)