Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caustics Parallax #16477

Merged
merged 6 commits into from Oct 28, 2023
Merged

Conversation

Mister-Moriarty
Copy link
Contributor

@Mister-Moriarty Mister-Moriarty commented Oct 15, 2023

[UI] [Feature]

About The PR:

Implements an undersea caustics parallax render source for use on Oshan. This layer is not present in the Trench, so to imply that the Trench is at a depth where starlight scarcely reaches it. This is also true for Nadir.

See demonstration here: https://discord.com/channels/182249960895545344/890231630097182720/1158151755306111037

Several new areas have been added to Oshan so to accommodate for parallax occlusion overlays, such as the sunken asteroids and derelict diner.

Why Is This Needed?

Oshan deserves some parallax layers too.

Changelog:

(u)Mr. Moriarty
(*)Oshan now has it's own parallax layer, depicting an undersea caustics pattern.

@keywordlabeler keywordlabeler bot added A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Feature A new feature or enhancements to existing features labels Oct 15, 2023
@boring-cyborg boring-cyborg bot added A-Mapping A mapping change C-Sprites Automatically applied on any .dmi or icons folder change labels Oct 15, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 15, 2023
@Laboredih123
Copy link
Contributor

Laboredih123 commented Oct 15, 2023

yo, image? i wanna see the funny lights

@Mister-Moriarty
Copy link
Contributor Author

yo, image? i wanna see the funny lights

Restricted once again by the 10MB file size limit.
Have a Discord link instead.

@ZeWaka
Copy link
Member

ZeWaka commented Oct 15, 2023

i personally think they're too bright/obvious/noticable

@TobleroneSwordfish
Copy link
Contributor

Agree, it looks amazing but could do with being just a little bit more subtle.

@Mister-Moriarty
Copy link
Contributor Author

Mister-Moriarty commented Oct 15, 2023

i personally think they're too bright/obvious/noticable

In the demonstration, the observer's larger light cone results in the layer appearing brighter. Without the light cone, the effect is much more subtle.

image

@ZeWaka ZeWaka self-requested a review October 16, 2023 02:11
@flappybatpal
Copy link
Contributor

flappybatpal commented Oct 16, 2023

Example recording from OBS
https://github.com/goonstation/goonstation/assets/70909958/e95456ae-948c-4fea-87e9-5e0423bf6735

Two things I found

  1. It shows over the sea elevator, this area is pathed as shuttle for some reason. If we are making map changes might as well adjust this here too.
  2. Shows over trench holes. Not quite sure of this, on one hand it looks quite pretty but on the other it's a hole so nothing for the light to hit?

@TobleroneSwordfish
Copy link
Contributor

In the demonstration, the observer's larger light cone results in the layer appearing brighter. Without the light cone, the effect is much more subtle.

I've tested it on local, yep, and I still think the strongest parts of the animation are just a little too obvious. Remember, Oshan has a daylight cycle (even if it's pitch black for most of UK time) so it will show up a lot more brightly during the day.

@flappybatpal
Copy link
Contributor

New changes are good. Uncertain about client performance implications of the large sprites, there seems to be more hitching but this is not a scientific analysis.

@TobleroneSwordfish TobleroneSwordfish added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Oct 20, 2023
@AXLFAN2000
Copy link
Contributor

This looks SUPER gorgeous ingame, and I had no performance issues with it in the classic round that just ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants