Roundstart takes about 20 seconds between the moment you were spawned in and the moment the game actually starts

[goonstation-issuebot]

Labels

[BUG][MAJOR]

Description

Roundstart takes about 20 seconds between the moment you were spawned in and the moment the game actually starts

Steps to reproduce

1- Roundstart
2- Spawn in
3- Wait 20 seconds before the game is actually launched

Expected Behavior

The usual 2-3 second roundstat

Additional Information & Screenshots

It wasn't happening before, but since a day or two, it's almost constantly 15+ seconds of wait.

Reported by: Chatauscours
Client version: 515.1635
On server: Goonstation 3 Roleplay: Morty
Active test merges: #18435, #18561, and #18275
Round log date: 2024-04-26-11-31
Reported on: 2024-04-26 11:38:01
Map: DONUT2

[Chatauscours]

Adding verified tag, since Iit seems it happens to everyone, see
https://discord.com/channels/182249960895545344/890223118482800790/1233151068301430803

[Chatauscours]

[TobleroneSwordfish]

Currently being worked on, still no idea what's causing the delay.

[Chatauscours]

I don't know if it's of any help, but I've noticed over the rounds that X is CE / HOP / RD / MD gets displayed very early on, as soon as you spawn in, however X is Captain gets displayed only after the delay. @TobleroneSwordfish

[pgmzeta]

Currently being worked on, still no idea what's causing the delay.

gut check here but i removed a SPAWN(0) that would be called during job distribution in #18482 - worth adding back to test?

[TobleroneSwordfish]

gut check here but i removed a SPAWN(0) that would be called during job distribution in #18482 - worth adding back to test?

!!!

[TobleroneSwordfish]

Okay yep, it was almost certainly #18482 - the SPAWN was around a choose_name call which blocks the call stack until the user chooses their name. So the entire roundstart process was being blocked until the clown decided which version of "Honk McHonkingson" they wanted to call themselves today.
Easy to miss in that big block of mostly uselessly SPAWNed code!

[TobleroneSwordfish]

I'll leave this issue open until we can verify it's no longer occurring on live.

[pgmzeta]

😔