Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gang locker movement #18561

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

TDHooligan
Copy link
Contributor

@TDHooligan TDHooligan commented Apr 19, 2024

[GAMEMODES][BALANCE]

About the PR

Lets gang leaders move their locker to somewhere in their territory once every 15 minutes.
Slightly increases the minimum range between lockers

Why's this needed?

1: When too close together, lockers cause excessive (almost boring) amounts of violence. Sec then have to get involved, and start patrolling the area. Which then causes more violence, and more lockdowns, and then everyone gets arrested, lockers get blockaded and nobody's having fun.

2: gangs occasionally just... firebomb/explode/plasmafire other lockers. and there's not much the other gang can do besides spend 20+ minutes fixing a hole/plasmafire. surefire win really.

Leaders experiencing too much stress will now be able migrate their locker to somewhere less miserable if they find that where they are isn't working.

There are probably a lot of interesting strategies this may open up. But I think it's a step forward in improving stalemates. And the problem cases can be addressed down the road.

Changelog

(u)TDHooligan
(*)Gang leaders can now move their locker to somewhere in their territory.

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Apr 19, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2024
@keywordlabeler keywordlabeler bot added A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs labels Apr 19, 2024
@Studenterhue Studenterhue added the E-Add-To-Wiki A PR that will require changes to the wiki label Apr 25, 2024
@goonstation-issuebot goonstation-issuebot added the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label Apr 26, 2024
Copy link
Contributor

@TobleroneSwordfish TobleroneSwordfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter also seems unhappy for some reason

code/datums/controllers/process/gang.dm Outdated Show resolved Hide resolved
@TDHooligan TDHooligan requested a review from Kyle2143 as a code owner May 20, 2024 18:30
@TobleroneSwordfish TobleroneSwordfish merged commit 1189402 into goonstation:master May 20, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
@goonstation-issuebot goonstation-issuebot removed the S-Testmerged [Dev Only] Testmerged for extended testing (applied by bot) label May 21, 2024
@Studenterhue Studenterhue removed the E-Add-To-Wiki A PR that will require changes to the wiki label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants