Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resist pins with WASD while unrestrained #10653

Merged
merged 1 commit into from Sep 5, 2022

Conversation

pgmzeta
Copy link
Contributor

@pgmzeta pgmzeta commented Sep 5, 2022

About the PR

Adds a check to resist pins with movement keys.

Why's this needed?

Better match other movement-restricted behavior: movement keys get you out of ice cubes and forces moves with other grabs.
Was suggested here: #9404 (comment)

Changelog

(u)glowbold
(*)While pinned, using movement keys resists against the pin.
(+)You can still use IKJL to flail uselessly while pinned.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2022
@pgmzeta pgmzeta added C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities and removed C-Feature A new feature or enhancements to existing features labels Sep 5, 2022
@pgmzeta pgmzeta marked this pull request as ready for review September 5, 2022 08:40
@ThatFiveGuys
Copy link
Contributor

Should apply to all grabs instead of just pins

@NightmareChamillian
Copy link
Contributor

honestly I don't think it should apply to all grabs- pins are unique in that they're pretty easy to force someone into, especially if they're new, and insanely hard to escape from. Choking grabs are harder to pull off than pins and have a few things that can prevent them, and aggressive grabs are really easy to break out of, as well as not always being made with hostile intent.

@ThatFiveGuys
Copy link
Contributor

ThatFiveGuys commented Sep 5, 2022

honestly I don't think it should apply to all grabs- pins are unique in that they're pretty easy to force someone into, especially if they're new, and insanely hard to escape from. Choking grabs are harder to pull off than pins and have a few things that can prevent them, and aggressive grabs are really easy to break out of, as well as not always being made with hostile intent.

The thing is 1. It seems unintuitive if wasd doesnt work for pins and works for grabs, and 2. Having wasd work doesnt make it easier to escape grabs because all it does is press resist for you on the same cooldown, it just makes it more intuitive and clear for new players to do. If making resisting grabs more intuitive makes grabs weaker due to more people actually knowing how to resist them that seems much more like a grab issue then a this change issue.

@Tarmunora Tarmunora merged commit 498af40 into goonstation:master Sep 5, 2022
github-actions bot pushed a commit that referenced this pull request Sep 5, 2022
@pgmzeta pgmzeta deleted the wasd-pin-resist branch December 24, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Player-Actions Relating to direct player actions, e.g. emotes, special attacks, abilities C-QoL A quality of life improvement that makes the game easier to play size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants