Adds in a new chaplain antagonist item, the heartlight knife #10761

Crackaduck · 2022-09-10T22:24:52Z

[INPUT WANTED]

About the PR

This PR adds in a new chaplain antag item, costing 6 TC, a scroll that once read, replaces the readers heart and grants them the ability to summon a slightly less powerful Infiltrator dagger for 8 seconds with a cooldown of 30 seconds.

The name's could use some work however, I'm iffy on them and open to change

Why's this needed?

The chaplain has very little in terms of unique antag items, aside from ones that lean more into RP aspects of the role than damage, it gives medbay a good reason to practice heart surgery, and syndicate knives are just a fun item to use.

Changelog

(u)Carsontheking
(+)Adds In a new antag item for chaplains!

[INPUT WANTED] ## About the PR  This PR adds in a new chaplain antag item, a scroll that once read, replaces a chaplains heart and grants them the ability to summon a slightly less powerful syndicate knife for 8 seconds with a cooldown of 30 seconds ## Why's this needed?  The chaplain has very little in terms of unique antag items, and syndicate knives are fun to use The name's could use some work however ## Changelog  ```changelog (u)Carsontheking (+)Adds In a new antag item for chaplains! ```

github-actions · 2022-09-10T22:25:23Z

Created discussion thread: https://forum.ss13.co/showthread.php?tid=19683

DimWhat

Couple description suggestions and some typos I found

code/obj/item/organs/heart.dm

code/obj/item/misc_weapons.dm

code/obj/item/organ_holder.dm

code/obj/item/device/sacred_heart.dm

code/datums/syndicate_buylist.dm

code/obj/item/organ_holder.dm

code/datums/syndicate_buylist.dm

code/obj/item/device/sacred_heart.dm

code/obj/item/organ_holder.dm

Crackaduck · 2022-09-10T23:35:00Z

Thank you all for the help, I'll be sure to start on it these changes later tonight. I'd also like to ask if anyone feels there ought to be any balance changes to this, be it the cooldown, damage delt, or time before deletion.

DimWhat · 2022-09-10T23:50:46Z

Just gonna note that you have a lot of unrelated sprite reversions in the DMI files you touched

Crackaduck · 2022-09-11T02:13:38Z

DimWhat, I Implemented most of the changes, thank you for the help, I did miss over one though, I'll get it at a later date I suppose

Crackaduck · 2022-10-04T07:15:26Z

will need to go back and resprite the heart possibly, along with sound design, but code wise I think its about done. Not sure what's going on with maps though...

Crackaduck · 2022-10-07T01:03:57Z

!merge_upstream

github-actions · 2022-10-07T01:05:36Z

Merging upstream failed:
https://github.com/goonstation/goonstation/actions/runs/3201515541

github-actions · 2022-10-21T01:17:32Z

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

…to chap-knife

Crackaduck · 2022-10-21T02:56:41Z

well it works now!

…to chap-knife

Azrun · 2022-10-27T23:21:06Z

Description seems misleading. This is based on the infiltrator knife and not the syndicate dagger?

Azrun

I'm not a weapons guy really but this feels a little weird to me. Essentially a very slightly weaker infiltrators knife.

Thematically I wish drawing the dagger out was more telegraphed and theatrical and/or traumatic in some way.

Is this trying to be a magic divine thing? Should it only work for chaplains or people with positive karma otherwise gib then?
Is it an artifact of some kind? Maybe it would be something you plunge into your head instead?

tl;dr I'm not sure I get it...

Azrun · 2022-10-27T23:06:44Z

code/obj/item/device/sacred_heart.dm

@@ -0,0 +1,58 @@
+#define HEART 1 // I couldn't find a way to make this work without the define, my coding is very primitive however.


This comment adds no value

what exactly do you mean by that? the primitive part, or the entire comment? I added it there because zonespace previously commented on the define being un-needed.

Azrun · 2022-10-27T23:10:24Z

code/obj/item/device/sacred_heart.dm

+		bleed(H, 5, 5)
+		SPAWN(5 DECI SECOND)
+			H.emote("scream")
+		icon_state = "sacred_heart_scroll-U"


What is the benefit of having the scroll still exist? Evidence?

ya mainly for evidence, and partially flavor. It makes it so you can't just use it in the corner of maint and never have to deal with at least disposing of it.

Azrun · 2022-10-27T23:12:49Z

code/obj/item/device/sacred_heart.dm

+		boutput(H, "<span class='alert'>You fill your heart with keen light !</span>")
+		end_replace_heart(HEART, H)
+
+	proc/end_replace_heart(var/target, var/mob/living/carbon/human/H)


target appears to be unused?

The code doesn't work without it, it messes up line 31 (bodypart = H.get_organ(part_loc) somehow.
If you have a solution I'd be happy to implement it.

code/obj/item/device/sacred_heart.dm

Azrun · 2022-10-27T23:19:13Z

code/obj/item/misc_weapons.dm

+
+	New()
+		..()
+		setProperty("movespeed", -0.4)


Why does this adjust move speed?

its a carry over from the syndicate infiltrator dagger, though nerfed comparatively. It helps give it utility and flavor, although if you believe it would be too powerful, it can be either nerfed or outright removed.

Crackaduck · 2022-10-28T03:12:11Z

Description seems misleading. This is based on the infiltrator knife and not the syndicate dagger?

yes it is, my mistake I'll change it now.

Crackaduck · 2022-10-28T03:19:25Z

Thematically I wish drawing the dagger out was more telegraphed and theatrical and/or traumatic in some way.
Would you say that adding in a audio que whenever the ability is used to tip people off would improve this?

Thinking on it, maybe it would be a good idea to add in either a light source from the knife whenever its active, and a sound that plays whenever the ability that produces it is used. Would you agree?

Is this trying to be a magic divine thing? Should it only work for chaplains or people with positive karma otherwise gib then? Is it an artifact of some kind? Maybe it would be something you plunge into your head instead?

Its trying to be divinely themed robotic implant of sorts, the idea being that it is made out of hardlight, though maybe rebranding it to be unstable hard-light would be more in line with the rest of the ss13 setting, given the lack of the technology and the fact it quickly disappears after initial use.

pali6 · 2022-10-30T17:46:42Z

I don't the the flavor of this quite fits. I'd probably lean more into it being a heart implant and away from the divine scroll stuff. But then it loses the connection with the chaplain so it doesn't fit either.

And overall the effect of the item doesn't sound particularly exciting to me at a glance.

Crackaduck · 2022-10-30T19:46:54Z

I don't the the flavor of this quite fits. I'd probably lean more into it being a heart implant and away from the divine scroll stuff. But then it loses the connection with the chaplain so it doesn't fit either.

do you feel like something like this would fit more? more syndicate looking with the little flourish of the waxed paper seal on to give a more chaplain feel?

And overall the effect of the item doesn't sound particularly exciting to me at a glance.

:( in all seriousness what do you think could be done to make it more chaplain orientated?
Maybe a chance of setting people on fire, stun damage, or dealing brain damage in addition to normal damage? Though in truth I don't know what I'd add myself, more spitting off possible additions to distinguish it as an item.

Crackaduck · 2022-11-06T21:14:41Z

so uh, any idea on the changes in response to the criticism?

pali6 · 2022-11-24T18:07:24Z

I think I'm overall just not a fan of this, sorry. It doesn't feel interesting nor as a cohesive enough design to me.

boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Sep 10, 2022

github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2022

keywordlabeler bot added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Sep 10, 2022

github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Sep 10, 2022

DimWhat reviewed Sep 10, 2022

View reviewed changes

Zonespace27 reviewed Sep 10, 2022

View reviewed changes

Crackaduck added 5 commits September 10, 2022 20:35

icons update

a14efa8

icons again this time fixing things for real

f842f8e

igniter plz

d064ecc

igniter sprite fix, PLEASE WORK

c6195b3

Dim's word use/spelling sugestions

e7f0189

Crackaduck added 4 commits September 11, 2022 15:28

minor corrections and true/false instead of 1/0

d63bbfc

chap_knife to chaplain_knife

4c05032

some more true falses I missed

4f073d1

Streamlined code and renaming to heartlight

e6f9f03

squeezy sound for heart

145cb55

Crackaduck changed the title ~~Adds in a new chaplain antagonist item~~ Adds in a new chaplain antagonist item, the heartlight knife Oct 6, 2022

github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Oct 21, 2022

Merge branch 'master' of https://github.com/Crackaduck/goonstation in…

298023b

…to chap-knife

github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 21, 2022

github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Oct 22, 2022

Crackaduck added 2 commits October 21, 2022 21:41

somehow created unwanted sprites, deleting them

7f1965f

Merge branch 'master' of https://github.com/Crackaduck/goonstation in…

7c59aeb

…to chap-knife

github-actions bot removed S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict S-Stale An inactive PR that has had no updates in the past two weeks labels Oct 22, 2022

Azrun reviewed Oct 27, 2022

View reviewed changes

inhand sprite works now plus light

9ae0581

FlameArrow57 added C-Feature A new feature or enhancements to existing features A-Gamemodes Changes or additions to any gamemode's main features labels Nov 16, 2022

pali6 closed this Nov 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds in a new chaplain antagonist item, the heartlight knife #10761

Adds in a new chaplain antagonist item, the heartlight knife #10761

Crackaduck commented Sep 10, 2022 •

edited

github-actions bot commented Sep 10, 2022

DimWhat left a comment

Crackaduck commented Sep 10, 2022

DimWhat commented Sep 10, 2022

Crackaduck commented Sep 11, 2022

Crackaduck commented Oct 4, 2022

Crackaduck commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 21, 2022

Crackaduck commented Oct 21, 2022

Azrun commented Oct 27, 2022

Azrun left a comment

Azrun Oct 27, 2022

Crackaduck Oct 28, 2022

Azrun Oct 27, 2022

Crackaduck Oct 28, 2022

Azrun Oct 27, 2022

Crackaduck Oct 28, 2022 •

edited

Azrun Oct 27, 2022

Crackaduck Oct 28, 2022

Crackaduck commented Oct 28, 2022

Crackaduck commented Oct 28, 2022 •

edited

pali6 commented Oct 30, 2022

Crackaduck commented Oct 30, 2022 •

edited

Crackaduck commented Nov 6, 2022

pali6 commented Nov 24, 2022

		@@ -0,0 +1,58 @@
		#define HEART 1 // I couldn't find a way to make this work without the define, my coding is very primitive however.

Adds in a new chaplain antagonist item, the heartlight knife #10761

Adds in a new chaplain antagonist item, the heartlight knife #10761

Conversation

Crackaduck commented Sep 10, 2022 • edited

About the PR

Why's this needed?

Changelog

github-actions bot commented Sep 10, 2022

DimWhat left a comment

Choose a reason for hiding this comment

Crackaduck commented Sep 10, 2022

DimWhat commented Sep 10, 2022

Crackaduck commented Sep 11, 2022

Crackaduck commented Oct 4, 2022

Crackaduck commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 21, 2022

Crackaduck commented Oct 21, 2022

Azrun commented Oct 27, 2022

Azrun left a comment

Choose a reason for hiding this comment

Azrun Oct 27, 2022

Choose a reason for hiding this comment

Crackaduck Oct 28, 2022

Choose a reason for hiding this comment

Azrun Oct 27, 2022

Choose a reason for hiding this comment

Crackaduck Oct 28, 2022

Choose a reason for hiding this comment

Azrun Oct 27, 2022

Choose a reason for hiding this comment

Crackaduck Oct 28, 2022 • edited

Choose a reason for hiding this comment

Azrun Oct 27, 2022

Choose a reason for hiding this comment

Crackaduck Oct 28, 2022

Choose a reason for hiding this comment

Crackaduck commented Oct 28, 2022

Crackaduck commented Oct 28, 2022 • edited

pali6 commented Oct 30, 2022

Crackaduck commented Oct 30, 2022 • edited

Crackaduck commented Nov 6, 2022

pali6 commented Nov 24, 2022

Crackaduck commented Sep 10, 2022 •

edited

Crackaduck Oct 28, 2022 •

edited

Crackaduck commented Oct 28, 2022 •

edited

Crackaduck commented Oct 30, 2022 •

edited