Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives lategame revs and crew revhead/head trackers #11015

Merged
merged 7 commits into from Oct 23, 2022

Conversation

ThatFiveGuys
Copy link
Contributor

@ThatFiveGuys ThatFiveGuys commented Sep 25, 2022

27-30 minutes past roundstart on a rev round, a broadcast gets sent out to everyone that gives every pda both a program for tracking revheads, and a program for tracking heads. This tracker shows the direction the nearest head is in, and the distance of the nearest head.

image

About the PR

Lategame revs can tend to drag on to become a game of side that has already practically won tracks down the single hidden/afk head remaining. This should give a climactic finish to rev rounds by making it a rush to defend/attack the remaining heads.

Why's this needed?

Changelog

(u)Ikea
(*)27-30 minutes into a rev round everyone recieves a tracker for revheads/heads on their pda.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2022
@ThatFiveGuys ThatFiveGuys added C-Balance Balance changes, buffs and nerfs E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. E-Add-To-Wiki A PR that will require changes to the wiki A-Gamemodes Changes or additions to any gamemode's main features and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=19803

@ThatFiveGuys ThatFiveGuys added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 25, 2022
@CaioFrancisco
Copy link
Contributor

A few things that I wanted to happen: the PDA program could be spread to Revolutionaries and Command around the same time the first few gibwave announcements start, so CentComm doesn't warn about revs twice. Another thing I noticed is the poor grammar in the announcements, so I'll send an improved version here:

A revolution has been detected on [station_name(1)]. A station-wide scan has revealed the causes of the revolution, and a PDA program has been sent to all the Heads of Staff.

For the head revs, there could be a more silent way to indicate this by sending a PDA message only to them, like shown on your screenshot. But all of this is just my idea, if you want to put it in your code is up to you.

@ThatFiveGuys
Copy link
Contributor Author

ThatFiveGuys commented Sep 25, 2022

To me the point of the first gibwave message is mostly to say “wrap shit up shit is about to get fucked if you dont”, I picked 27-30 minutes into the round for tracker being sent out as thats when rev rounds feel like they should begin the third act.

I dont want the tracker to be limited in who its sent to for a few reasons. First off its not unusual to have the last heads remaining afk and this could easily kill the momentum of a side in its tracks which seems bad. Finally, i want this to be the start of a proper conclusion for rev rounds. Currently rev rounds just kind of end abruptly after one side has already basically won and its several minutes of mostly non action, this sucks. The intent here is that by giving everyone the program at once, you cause everyone to swarm to defend/attack heads, this should cause a bunch of holdouts, lone wolf operations, and all around just a lot of action and chaos. I think limiting this program to only a few people would severely limit that.

I dont understand whats wrong with the modified announcements? The intent here is for the announcements to even be more of “okay stop playing around get shit done”, and i think the “revolution is still ongoing” conveys that well

@CaioFrancisco
Copy link
Contributor

CaioFrancisco commented Sep 25, 2022

fair enough, the only complaint left is just the grammar on the announcements and what seems like a lack of explanation for a few things. PDA is an acronym (personal data assistant) and you probably meant "PDA's" as in plural. it's probably just me, but "station-wide" and "on-going" sound much better with the dashes, the announcements would feel more appropriate if they had the same tone as when it's gangs and CentComm just wants shit to be done and the initial announcement would be better if it already told you that it's a revolution, not a foreign mutiny.

@Conchuckter
Copy link
Contributor

Something to note is that if someones PDA is full then they will not receive it, this could be exploited if someone decided to spam file transfers to intentionally fill the crews PDA's.

@ThatFiveGuys
Copy link
Contributor Author

I seriously doubt that will happen and will probably violate the rules due to it requiring spamming pdas with measages so im not too concerned

@ZeWaka
Copy link
Member

ZeWaka commented Sep 27, 2022

I seriously doubt that will happen and will probably violate the rules due to it requiring spamming pdas with measages so im not too concerned

this is pretty trivial and i wouldn't consider this against the rules on antag grief

Copy link
Contributor

@Conchuckter Conchuckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The annoucements need some work as others have said, stuff like pda needs to be in uppercase.

code/datums/gamemodes/revolution.dm Outdated Show resolved Hide resolved
@ThatFiveGuys
Copy link
Contributor Author

fair enough, the only complaint left is just the grammar on the announcements and what seems like a lack of explanation for a few things. PDA is an acronym (personal data assistant) and you probably meant "PDA's" as in plural. it's probably just me, but "station-wide" and "on-going" sound much better with the dashes, the announcements would feel more appropriate if they had the same tone as when it's gangs and CentComm just wants shit to be done and the initial announcement would be better if it already told you that it's a revolution, not a foreign mutiny.

Forgot to respond for this, I chose a very clinical tone for centcomm as I thought itd be most fitting, and I wanted the two announcements to be distinct. The reason why I used foreign mutiny first is because using the term revolution didnt seem fitting for Centcomm to describe the round as. Im not worried about clarity here as the fact that its a rev round should be very clear and I used the term rev leader specifically to specify what the tracker does. I dont think the dashes look as good

I didnt want to specify entirely what was going on because I think it fits most for you have to put a few things together to get the full picture. Since the syndicate doesn't have full access to the station, the syndicate broadcast is piggybacked ontop of centcomm sending the tracker. The pda isn't the thing actually tracking the heads lore wise, its the sensor arrays, hence why the syndicate has to identify the biometric signatures of command and not just send it out instantly. The reason why the gibwave comes so late is that just in case, nanotrasen wants to truly confirm that the signatures they had for the revheads are correct (hence the "The Revolutionary heads' biometric signatures have been confirmed.")

@ThatFiveGuys
Copy link
Contributor Author

Sending files to pdas through file_send on pdas now requires a new netpass_centcom, meaning you can no longer spam pda's with files unless you manage to sniff the message that sends out the tracker message.

@Conchuckter
Copy link
Contributor

Conchuckter commented Sep 28, 2022

Sending files to pdas through file_send on pdas now requires a new netpass_centcom, meaning you can no longer spam pda's with files unless you manage to sniff the message that sends out the tracker message.

This breaks a ton of stuff, and using batt_adjust doesn't make much sense since it's to 'control' the battery. You could instead set aside some storage space that can only be written to when netpass_centcom is present, or you could send a file_send_req and send the file to each PDA only when they reply with file_send_acc.

@ThatFiveGuys
Copy link
Contributor Author

I just used batt+adjust because its what detomatix uses and I dont know packet stuff tbh

@ThatFiveGuys
Copy link
Contributor Author

Just decided on setting the file sizes to zero

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Oct 17, 2022
@ZWRh3
Copy link
Contributor

ZWRh3 commented Oct 23, 2022

i agree that revs would benefit from mass trackers as once one side is loosing it turns into pod/locker hide and seek rather than revs just today half the heads delayed the round by around 20 minutes by hiding in lockers

revs as in the gamemode

@ZeWaka ZeWaka added C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. and removed S-Stale An inactive PR that has had no updates in the past two weeks labels Oct 23, 2022
@ZeWaka
Copy link
Member

ZeWaka commented Oct 23, 2022

Let's try this out.

@ZeWaka ZeWaka merged commit 6fc3509 into goonstation:master Oct 23, 2022
github-actions bot pushed a commit that referenced this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs C-Experimental Involves changes that are a WIP and will require testing, feedback, and additional modification. E-Add-To-Wiki A PR that will require changes to the wiki E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants