Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds base chems to chemical request console #11330

Merged
merged 5 commits into from Oct 13, 2022
Merged

Adds base chems to chemical request console #11330

merged 5 commits into from Oct 13, 2022

Conversation

TobleroneSwordfish
Copy link
Contributor

[FEATURE] [QOL] [CHEMISTRY]

About the PR

Just adds any chemical that can be dispensed from a chem dispenser to the chem request console.

Why's this needed?

https://forum.ss13.co/showthread.php?tid=19926

Changelog

(u)LeahTheTech
(+)Added basic chemicals to the chemical request console.

@keywordlabeler keywordlabeler bot added A-Chemistry Deals with the chemistry system in some way C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play labels Oct 12, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2022
Tarmunora
Tarmunora reviewed Oct 12, 2022
View reviewed changes
code/modules/chemistry/Chemistry-Dispenser.dm Outdated
Comment on lines 39 to 40
if (!src.dispensable_reagents)
src.dispensable_reagents = basic_elements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>not refactoring the default chem dispenser into a subtype of an abstract parent 😔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but map changes aaaaa

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Oct 12, 2022
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2022
@TobleroneSwordfish
Copy link
Contributor Author

Okay fiiiine I made it a child of an abstract parent and replaced all instances using this regex
image
now pls merge before it map conflicts and everything explodes <3

@TobleroneSwordfish
Copy link
Contributor Author

okay well the bot is mad because I touched The Forbidden Maps, feel free to merge this regardless or tell me to revert

@Tarmunora Tarmunora merged commit f814f93 into goonstation:master Oct 13, 2022
github-actions bot pushed a commit that referenced this pull request Oct 13, 2022
@robuddybot
Changelog for #11330 [skip ci]
4c0b55e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarmunora Tarmunora Awaiting requested review from Tarmunora

Assignees
No one assigned
Labels
A-Chemistry Deals with the chemistry system in some way A-Mapping A mapping change C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TobleroneSwordfish @Tarmunora