Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial Interdictor QoL and efficiency improvement pass #11513

Merged
merged 2 commits into from Nov 7, 2022

Conversation

Kubius
Copy link
Contributor

@Kubius Kubius commented Oct 22, 2022

[FEAT][QOL][BALANCE]

About the PR

Substantially improves the process of creating spatial interdictors in several key facets.

  • Reduces the duration of most action bars during the interdictor assembly process, cutting nine seconds off of the previous total time (pre-engineer training).
  • Dramatically reduces the required materials for interdictor phase-control rods. All rods are now standardized to 0.2 MET-2 (from 1), 1 conductor based on tier (previously 2 to 2.5), 0.5 first-layer material (previously 1), and 0.2 second-layer material (previously 0.5).
  • Interdictor mainboards are now included with the assembly kit, adding a requirement of 0.4 conductive metal but removing the step where these boards had to be scanned and reverse-engineered to produce more interdictors.
  • As mainboards are now included, the interdictor crate now includes three uncharged power cells, as cells are a necessary step in interdictor assembly.

Some associated names, paths and bits of documentation (in-game and out) were changed to more accurately reflect the new state of the assembly process.

This is tagged Balance due to the potential ramifications for severity of random events, should these become popular; my belief is that if Engineers go to the trouble of making a bunch of these things, the protection that's afforded should match their effort (which it probably should after this, as opposed to only giving you patchwork protection unless you're dumping in a colossal amount of minerals).

Why's this needed?

Interdictors in their current state are unduly expensive and tedious to create given their role as a preventative device; improvements to this process should make them a more appealing option for Engineers to pursue.

Changelog

(u)Kubius
(*)Spatial interdictors are now quicker to assemble, require fewer secondary assembly steps and consume much fewer materials.
(+)Spatial interdictor mainboards are now part of the kit created at manufacturers, and no longer need to be separately scanned and reproduced.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play labels Oct 22, 2022
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2022
@TobleroneSwordfish TobleroneSwordfish added the A-Game-Objects The point of this PR is to deal with a specific game object label Oct 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Nov 7, 2022
@flappybatpal flappybatpal merged commit 16a8263 into goonstation:master Nov 7, 2022
github-actions bot pushed a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features C-QoL A quality of life improvement that makes the game easier to play S-Stale An inactive PR that has had no updates in the past two weeks size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants