Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dive suit manufacture capability for mining fabricators #11551

Merged
merged 1 commit into from Oct 26, 2022

Conversation

Kubius
Copy link
Contributor

@Kubius Kubius commented Oct 23, 2022

[FEAT][BALANCE][GAME OBJECTS]

About the PR

Creates /datum/manufacture/engdivesuit, "Engineering Diving Suit Set", which manufactures precisely that at the same cost as a space suit set.

Introduces said datum to the Mining Fabricator. This exists alongside the space suit manufacture datum instead of replacing it to avoid confusion regarding QM requisitions that ask for a space suit (dive suits also work for this purpose due to acceptance of subtypes, but that wouldn't be immediately clear and makes less sense thematically).

Why's this needed?

Allows for appropriate environmental gear manufacture in underwater maps.

This is most notable for Nadir as proper dive suits provide the best longevity against acid, and they can't currently be manufactured; this is the reason for the Balance tag and major changelog entry.

Changelog

(u)Kubius
(*)Mining fabricators are now capable of manufacturing dive suits while on an underwater map.

@keywordlabeler keywordlabeler bot added A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features labels Oct 23, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2022
@Sord213 Sord213 merged commit 9a94df2 into goonstation:master Oct 26, 2022
github-actions bot pushed a commit that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Balance Balance changes, buffs and nerfs C-Feature A new feature or enhancements to existing features size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants