Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes owner names from organs/limbs #11641

Closed
wants to merge 1 commit into from
Closed

Removes owner names from organs/limbs #11641

wants to merge 1 commit into from

Conversation

frawhst
Copy link
Member

@frawhst frawhst commented Oct 28, 2022

[FEEDBACK] [REMOVAL] [BALANCE]

About the PR

Title.
Notably does NOT remove owner names from hair or skulls- hair because it's probably recognizable already, and skulls because of the in-hand interaction where you yell the owner's name. I could remove the latter though.

fixes #11639 incidentally.

Why's this needed?

Dumb that I can recognize a disembodied leg on the ground. Makes forensics less useful.

(u)aloe
(+)Limbs and organs no longer bear the names of their owners.

@keywordlabeler keywordlabeler bot added C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature C-Removal Removal of an existing feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. labels Oct 28, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2022
@frawhst
Copy link
Member Author

frawhst commented Oct 28, 2022

bug???

@frawhst frawhst removed the C-Bug A bug that impacts usage of a feature label Oct 28, 2022
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=20032

Comment on lines +92 to +96
//https://forum.ss13.co/showthread.php?tid=1774
// aloe note - removing this again.
// SPAWN(2 SECONDS)
// if (new_holder && istype(new_holder))
// name = "[new_holder.real_name]'s [initial(name)]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//https://forum.ss13.co/showthread.php?tid=1774
// aloe note - removing this again.
// SPAWN(2 SECONDS)
// if (new_holder && istype(new_holder))
// name = "[new_holder.real_name]'s [initial(name)]"

@MarkNais
Copy link
Contributor

I think it is funnier to have names on limbs / organs and should stay for that reason.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 1, 2022
@github-actions github-actions bot closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Balance Balance changes, buffs and nerfs C-Removal Removal of an existing feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Stale An inactive PR that has had no updates in the past two weeks size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changeling limb names can show a name other than the current transformation name
3 participants