Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to how Flockbits and Flockdrones use items and guns #11684

Merged
merged 9 commits into from Jan 15, 2023

Conversation

FlameArrow57
Copy link
Contributor

@FlameArrow57 FlameArrow57 commented Oct 29, 2022

[GAME MODES][BALANCE]

About the PR

This PR just makes it so that when Flockbits and Flockdrones attack with an item, the item does much less brute and stamina damage than usual. For guns, they can no longer gun grab.

Why's this needed?

Flock is already meant to be dangerous, it's not fun when they just start killing people with items

Gun grabs don't make sense considering their grip tools are supposed to be weak

Changelog

(u)FlameArrow57
(+)Flockdrones will now deal less damage when attacking with items and point-blank shoot instead of gun-grab.

@keywordlabeler keywordlabeler bot added A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs labels Oct 29, 2022
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2022
code/mob/living/critter/flockcritter_parent.dm Outdated Show resolved Hide resolved
code/mob/living/critter/flockcritter_parent.dm Outdated Show resolved Hide resolved
@pali6
Copy link
Member

pali6 commented Oct 29, 2022

Chance to fail never feels good, I don't like this approach.

@FlameArrow57
Copy link
Contributor Author

Made it do less damage on hitting something. Not sure about guns, if it's fine or could maybe increase shoot spread

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2022
@ZWRh3
Copy link
Contributor

ZWRh3 commented Nov 1, 2022

last thing we need is more rng in combat

@FlameArrow57
Copy link
Contributor Author

Would like more feedback on preferred way of implementing this

@TobleroneSwordfish
Copy link
Contributor

The way I'd do it is make an attack strength modifier var on /mob or /mob/living/critter and then take that into account in the parent attack proc. Not sure if that's the best way, but it's definitely better than directly modifying force or spawning nulled items.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2022
@FlameArrow57 FlameArrow57 marked this pull request as draft November 11, 2022 04:26
@FlameArrow57
Copy link
Contributor Author

FlameArrow57 commented Nov 12, 2022

Then for guns, Flock completely unable to use them, much wider angle of spread, or else? Not sure how feasible changing angle of spread is

@TobleroneSwordfish
Copy link
Contributor

Might also want to make it affect stamina damage since stamcritting people is usually the main thing flock use weapons for. As for guns, I think the current balance is okay? It's not like a drone can reliably reload, they already can't use energy weapons, and they're usually incentivized to eat a kinetic as soon as possible to avoid it being retrieved.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
@FlameArrow57 FlameArrow57 changed the title Make it harder for Flockbits and Flockdrones to attack with items and guns Make it harder for Flockbits and Flockdrones to attack with items Nov 16, 2022
@FlameArrow57 FlameArrow57 changed the title Make it harder for Flockbits and Flockdrones to attack with items Make changes to how Flockbits and Flockdrones use items and guns Nov 16, 2022
@FlameArrow57 FlameArrow57 marked this pull request as ready for review November 16, 2022 02:45
@FlameArrow57
Copy link
Contributor Author

Ready for review

@pali6
Copy link
Member

pali6 commented Nov 19, 2022

Is the current PR description and changelog entry correct?

@FlameArrow57
Copy link
Contributor Author

Yeah

@github-actions github-actions bot added the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 1, 2022
@github-actions github-actions bot removed the S-Merge-Conflict Applied and removed when a PR has or no longer has a merge conflict label Dec 1, 2022
@TobleroneSwordfish
Copy link
Contributor

Attack strength stuff looks good, not sure about the guns not firing though, a lot of the time when you're shooting something you're not clicking on exactly what you want to hit so could lead to a lot of clicks just going missing when you're trying to shoot someone in front of flock structures.
sry for late review I forgor

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Dec 17, 2022
@github-actions github-actions bot closed this Dec 25, 2022
@amylizzle amylizzle reopened this Jan 14, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. S-Stale An inactive PR that has had no updates in the past two weeks labels Jan 14, 2023
Copy link
Contributor

@amylizzle amylizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobleroneSwordfish TobleroneSwordfish merged commit b98ef95 into goonstation:master Jan 15, 2023
github-actions bot pushed a commit that referenced this pull request Jan 15, 2023
@FlameArrow57 FlameArrow57 deleted the attack-change branch February 2, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gamemodes Changes or additions to any gamemode's main features C-Balance Balance changes, buffs and nerfs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants