New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod Wars Team Planning Maps #12733
Pod Wars Team Planning Maps #12733
Conversation
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely cool, I wasn't aware this had actual pilot tracking too. The code overall looks good, I'm a little concerned about the memory impacts of shoving every solid turf in a 500x500 z level in a list, but it seems to load fine and is only a roundstart issue anyway.
The minimap markers on the map controllers are ludicrously small currently, to the point of being 1-2 pixels (probably caused by the larger map size)
A turf will only be placed into that list should the area containing it have a non-null
Regarding the miniscule markers, I foresee that requiring a resizing system for minimap markers, which I will hopefully begin work on soon. Thank you for the review! |
Minimap markers should now appear at the correct size on minimaps displayed on the UI, currently being scaled as to be the same size relative to the minimap as the physical minimap markers are to the physical minimap. |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
fuu |
Yes, this is amazing. This is something I had "planned" to add to each ship shortly after releasing pod wars. This has literally all the features I had considered for this(though at the time I was imagining it "hologram-y", but never had any clue what that would really look like), so I wonder if I actually wrote it down or this is just such a logical feature that anyone would arrive at it. I remember Sov pitched a good way to implement this, but I never got around to it cause I was already starting to wind down for a while and have been not here. |
[Feature] [Gamemodes] [Add To Wiki]
About the PR:
Expands upon the physical station minimaps feature implemented in #12463 and previous PRs to work with maps of any size, and adds map displays and controller computers to the Bridge of both the NSV Pytheas and Lodbrok.
Each debris field map computer will display the location of both pod carriers, the three control points, all minor areas, asteroids, and warp beacons, and the location of every living member of the respective team. Should one of the teams capture a control point, the colour of the control point on the minimap will change to the primary colour of the capturing team. Their controllers operate in the same way as the handheld controller on the Cairngorm.
To this end, a minimap renderer datum has been created, which will handle all operations related to drawing the minimaps, and allow for specific areas to be drawn separately on an
atom/movable
for easy recolouring across various minimap instances. Each pod pilot will also receive a special tracking implant, and the Bridges of the two pod carriers have been redesigned.Why's this needed?
While static debris field maps already exist, an additional live, high visibility minimap will help aid coordination within teams, especially in matters of determining where to stage an assualt, where all players on a team are currently at, and in navigating the field.
Changelog: