Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mauxite Construction Sprites #12790

Merged
merged 5 commits into from Feb 8, 2023
Merged

Conversation

Flaborized
Copy link
Contributor

@Flaborized Flaborized commented Jan 17, 2023

[FEAT]

About the PR

This PR makes it so some stuff made out of mauxite uses unique sprites instead of the material color being applied to the base. This includes:

  • Walls + Rwalls
  • Floors (Though floors with non-default patterns will currently use the patterned sprite. Might need to be fixed idk?)
  • Lockers
  • Stools
  • Material sheets, rods, floortiles (Currently doesn't work, needs some code fix that I dunno how to do)
  • Chairs
  • Tables

Also change the default mauxite color to match these sprites

Why's this needed?

I think this is a fun way to implement new building options, while also giving some aesthetic values to materials. Mauxite is just an arbitrary 'first' thing to work on, I plan to (and others can also) add stuff for other appropriate building materials, so you can have lots of options and uses for all the stuff mining can procure. Also the rusty industrial look could be useful for some prefabs which I've seen mentioned/been asked about on discord.

Works with the new fancy $$ material tag stuff that Amy coded and pali helped me out with. Very strong and useful toolkit for making this kinda stuff with more or less no additional code.

Changelog

(u)Flaborized
(+)Added unique sprites for many construct-able things made out of mauxite sheets, for that industrial warehouse look. Includes walls, floors, tables, and chairs. Go build stuff with it! Mind the rust.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Jan 17, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Jan 17, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2023
@BatElite
Copy link
Contributor

BatElite commented Jan 17, 2023

Interesting changelog :P

@M-Earthfire
Copy link
Contributor

How will this interact with alloys containing mauxite?

The sprites are lovely!

@Flaborized
Copy link
Contributor Author

Interesting changelog :P

Whoops, fixed!

How will this interact with alloys containing mauxite?

The sprites are lovely!

It won't change sprites of alloys, just pure mauxite. It might change them if you make an alloy that's named 'mauxite', but then it won't inherit the alloy color or anything. But why would one do that !

@ZeWaka ZeWaka added the A-Materials Deals with our materials system in some way label Jan 18, 2023
@ZeWaka
Copy link
Member

ZeWaka commented Jan 18, 2023

if it's wip,

@ZeWaka ZeWaka marked this pull request as draft January 18, 2023 17:34
@WALPVRGIS
Copy link
Member

Cool as hell sprites Flabo :000000 !!

@Flaborized
Copy link
Contributor Author

Flaborized commented Jan 20, 2023

Added tables, chairs, changed the material color to match the rest of everything. (So objects without unique sprites will be closer looking to these bespoke ones) Also the sheets and rods and tiles weren't broken actually! With that, I've added the features I wanted to add so draft removed

image

@Flaborized Flaborized marked this pull request as ready for review January 20, 2023 17:49
@ZeWaka ZeWaka merged commit 5aee7c2 into goonstation:master Feb 8, 2023
github-actions bot pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Materials Deals with our materials system in some way C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants