Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cyborgs removing items from humans #12876

Conversation

flappybatpal
Copy link
Contributor

About the PR

Fixes #12866

Why's this needed?

No-one expects borgs to remove items. Borgs cannot hold or add items.
Balance questions from borgs ability to remove internals, equipment, handcuffs.

Changelog

(u)Flappybat
(+)Prevent cyborgs removing items from humans.

@flappybatpal flappybatpal added C-Bug A bug that impacts usage of a feature C-Balance Balance changes, buffs and nerfs A-Silicons Deals with the angry metal robots S-Controversial This requires a heightened standard of review before it can be merged labels Jan 25, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2023
@Wisemonster
Copy link
Contributor

Not sure I particularly like the idea of removing borgs ability to remove items. If the logic is "they don't got hands, so shouldn't be able to." then this also brings up the question of whether they should be able to drag items behind them. This also will prevent them from dealing with issues such as removing an empty internals tank, "bad clothes" (ex. wrestle belt, wizard gear, bowling clothes, etc.), or actively harmful equipment.

@Wisemonster Wisemonster added the E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. label Jan 25, 2023
@github-actions
Copy link
Contributor

Created discussion thread: https://forum.ss13.co/showthread.php?tid=20586

@ghost
Copy link

ghost commented Jan 26, 2023

makes sense to me

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Feb 10, 2023
@github-actions github-actions bot closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Silicons Deals with the angry metal robots C-Balance Balance changes, buffs and nerfs C-Bug A bug that impacts usage of a feature E-Input-Wanted Input and feedback are wanted. Also posts a discussion thread on the forums. S-Controversial This requires a heightened standard of review before it can be merged S-Stale An inactive PR that has had no updates in the past two weeks size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Borgs and Shells can strip items despite lacking arms
2 participants