New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworks and adds a few flags (the fabric kind) #12926
Conversation
Why not just have a generic flag that can be painted like a canvas? |
we've already got banners tho i should add: the main reason why i'm implementing flags as their own thing as opposed to just BEEFing up banner code is primarily for mapping and so we could have a fun pre-made asset to decorate things with. i suspect the confusion might be brought about due to the inclusion of the blank flag, so i'd be perfectly happy to just turn that into an abstract type and killing it all together* *i forgot that white flags have actual meaning, woops, we could put some more thought into it |
This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself. |
Opening this PR as-is for review (since this was never actually opened). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems cool
Co-authored-by: TobleroneSwordfish <20713227+TobleroneSwordfish@users.noreply.github.com>
[MAPPING][OBJECTS][FEATURE][REWORK]
About the PR
This PR re-organises
obj/decal/wallsign/flag
into its own type,obj/decal/poster/flag
, and introduces a newobj/item/flag
that can be placed on walls much like fabric banners (#5036). Flags can also now be taken down from walls by attacking them with a free hand. All instances of flags in the public repository have been updated with the new file path. I hope.Also, more flags. Thanks to Geonightman#2706 on Discord for making the icons for these.*
*this has been updated like numerous times sorry (accurate as of 1 feb 2023)
I drew the folded flag states and the blank flag stuff and I don't love them, feedback will be appreciated.
All of the flags, save for the lesbian pride ones, are currently player-unobtainable.
Why's this needed?
Flags are nice and I wanted them for a thing.