Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requisition de-bork batch #13259

Merged
merged 1 commit into from Mar 6, 2023
Merged

Conversation

Kubius
Copy link
Contributor

@Kubius Kubius commented Mar 3, 2023

[BUGFIX]

About the PR

Fixes two issues with requisition entry handling with some additions to the entry code and according changes in entries themselves.

  • Adds an optional material ID parameter to the item stack entry; if defined, requires the provided material ID string to match one present on the stack. This is now used for steel sheet stack evaluation instead of the path, as the path isn't maintained when splitting sheet stacks. Much better.
  • Adds and implements a new "food item" entry type that's aware of bites_left, now that that's a distinct thing from amount. Default behavior is to require initial bites_left on food (in other words: intact) and count per food item, but incrementing based on bites_left is also supported (currently used only for pizza, to allow slices).

Why's this needed?

Fixes #9809, #9889 and #13227.

Changelog

(u)Kubius
(+)Fixed some requisition handling goofs that could cause orders to fail, most notable in the handling of steel sheets for an aid contract.

@keywordlabeler keywordlabeler bot added the C-Bug A bug that impacts usage of a feature label Mar 3, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2023
@ZeWaka ZeWaka added the A-Events Deals with game events, like meteor showers and such label Mar 6, 2023
@ZeWaka ZeWaka merged commit 65645a6 into goonstation:master Mar 6, 2023
github-actions bot pushed a commit that referenced this pull request Mar 6, 2023
Valtosin pushed a commit to frosty-dev/rugoon that referenced this pull request Apr 22, 2023
Valtosin pushed a commit to frosty-dev/rugoon that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Events Deals with game events, like meteor showers and such C-Bug A bug that impacts usage of a feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impossible cargo order req
3 participants