fix item spinning messages #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjdtmkhzt
added
P-Trivial
zjdtmkhzt
commented
Jul 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[minor]
About the PR
This makes it so that spinning items should show messages again like it did before this pair of commits.
0319e02 8c3fd2f
Since the return value of onspin wasn't actually assigned to message and the parent of onspin wasn't actually called, no message was made.
Since I made it so that all onspins now call their parent, it also has the side effect of making it possible to drop things like guns/reagent containers. I think this is ok?
Why's this needed?
Features should work and spinning your gun makes you look cool.
related forum thread