Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captain Megaphone #13853

Merged
merged 3 commits into from May 1, 2023
Merged

Captain Megaphone #13853

merged 3 commits into from May 1, 2023

Conversation

Flaborized
Copy link
Contributor

@Flaborized Flaborized commented Apr 26, 2023

[FEAT]

About the PR

Adds a megaphone to the captains locker. Holding the megaphone in your hand and speaking will make your maptext larger and your voice louder! (Larger in chatbox). Since you're the most important person on the station you can now have the easiest to read text to match! (Or have it be stolen and be shamed as it's used against you)
Has an emag effect 👁️ (Non-gameplay-altering)

Compatible with the red and blue captain medals (if you hold it in your hand while activating)

Why's this needed?

I think it's a fun cute lil feature! Wanted to make this for a while and have finally gotten around to it. Helps the captain feel like they have a "commanding presence". Really just for fun roleplaying purposes though. Can be var edited to make the text much larger if an admin pleases.

Only one on the station so hopefully not a very annoying item either! I tried to balance it being noticeable but not obnoxious.

Changelog

(u)Flaborized
(+)The captain's locker has been stocked with a megaphone to help them get their finer points across.

@keywordlabeler keywordlabeler bot added the C-Feature A new feature or enhancements to existing features label Apr 26, 2023
@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label Apr 26, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2023
@DisturbHerb
Copy link
Contributor

DisturbHerb commented Apr 26, 2023

At one point many moons ago, one of the HoSii did suggest adding such a megaphone to the Armory. Not sure if that'd fit, but the option is there. 👀

@muzcl
Copy link
Contributor

muzcl commented Apr 26, 2023

Having the emag effect cause ear damage would be nice, not many things deal ear damage in this game I can think of. If its too overpowered like that, you could make it break after a few uses to balance it.

@@ -466,6 +466,13 @@
if (src.get_brain_damage() >= 60)
speechverb = pick("says","stutters","mumbles","slurs")

if (src.find_type_in_hand(/obj/item/megaphone))
var/obj/item/megaphone/megaphone = src.find_type_in_hand(/obj/item/megaphone)
if (megaphone.makes_you_quieter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (megaphone.makes_you_quieter)
if (megaphone.makes_you_quieter)

Comment on lines 1111 to 1112
popup_style = "font-size: [megaphone.maptext_size]px;"

Copy link
Contributor

@Azrun Azrun Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be += otherwise it will replace the bioeffects?
/datum/bioEffect/speech/comic and others

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond scope of this PR: Having the megaphone return the "" to modify the style would would open this up for all kinda of fun chaos. Also moves the logic for what to do the megaphone to entirely in the megaphone code.

@Flaborized
Copy link
Contributor Author

Undrafting this since I added the things I think I can add to this. Made the text bold and green (with a slight dark green outline) to better help it stand out and make it look less... thin. Added blue and red variants that you can get by holding it and activating the correct medals.

As for the sound, I tried for a while to mix something good in audacity but I can't really make something passable! I'm ok adding it without a sound and I can't personally provide one I'm happy with in the time frame I wanna work on this for :sheltersweat:

new look:

@Flaborized Flaborized marked this pull request as ready for review April 27, 2023 11:48
@Sord213 Sord213 merged commit 905198e into goonstation:master May 1, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Feature A new feature or enhancements to existing features C-Sprites Automatically applied on any .dmi or icons folder change size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants