Add artifact bag of holding

[FlameArrow57]

[GAME OBJECTS][FEATURE]

About the PR

This PR adds a new handheld artifact, the bag of holding.

The bag of holding is an artifact that acts as a storage, just like a box, but that has more variety in how it stores things or acts.

It comes in three varieties, depending on origin.

Eldritch-
Eldritch bags of holding are a general variety storage, which can hold anywhere from a few to a good amount of items, from tiny to bulky. Higher size capacities are more rare for higher slots. However, this type has no visible HUD, and items stored in them are stored in a FIFO, LIFO, or random order. FIFO/LIFO/random order idea from Flourish.

Martian-
Randomized, "shape-shifting" storage. Every so often, its storage slots and max holdable size will randomize. They can always be worn on your belt or back.

Wizard-
This is a large storage artifact that can hold from a few to a lot of items from tiny to small sized. However, you can only see a smaller number of the items in the storage at a time, and every time you add an item, take an item out, or look in the storage, you see a random set of items. Idea from zjdtmkhzt.

Larger storages can be worn on belts, for Martian, or your back, for all types. Artifacts transform their icon state when put in a belt or back slot.

Faults can trigger when storing items.

If you manage to put a bag of holding into a bag of holding, something bad happens too which can include
-Explosions
-Black holes
-Getting trapped in a pocket dimension
-Contents teleporting randomly

A side effect of the current rustle effect with how handheld artifacts are coded/sprited right now is that the sprite will flip sideways or upside down for rustles sometimes

Sprites made by DimWhat (Wizard sprites by my self)-

Why's this needed?

It'd be cool to see a handheld/wearable storage artifact, since that would allow for more fun and varying storage items

Changelog

(u)FlameArrow57 and DimWhat
(*)Added the bag of holding artifact! Appears with three variants. Ones with larger storages can be worn on your back, and the Martian one on your belt too.

[flrsh]

I definitely like the idea of storage artifacts, though storage in general can be rather annoying to balance and I'm unsure about just making these straight up Better Storage. Personally I'd like these more if there were weirder aspects you had to work around, e.g. FIFO / LIFO, all of one type share the same storage, etc.

[FlameArrow57]

Okay, yeah, makes sense. FIFO/LIFO/random pick is possible through another PR I'm working, #13961, which I think would be fun to add, I'll try to work on some more things like that

[zjdtmkhzt]

This seems really cool!

Yeah, storage is a hard thing to balance, in addition to things like LIFO/FIFO/random there could also be something like a type with infinite storage, but which only ever shows a random selection from all stored items as available.

Maybe watch out with the naming on things like "fault" for the burning stuff, because artifact faults are already a specific artifact mechanics, so it could potentially be confusing to talk about in coder talk.

If some of these can be worn, maybe there should be a worn sprite for them? I was under the impressions most larger wearable containers, like backpacks or belts had them.

[amylizzle]

Very cool, though personally I think all artifacts ought to be activated before they can be used. I've been meaning to fix artifact beakers not doing that for a while now.

[Exester509]

For the wizard one, it would be really cool if on fail it swapped the item for a note saying "This item has been confiscated by the Space Wizard Federation" or something similar. I'd find it a hilarious fail

[Glamurio]

Some of these should have a chance to spawn with a random array of items in them, akin to how beakers have random chems. Would add an additional layer of lootbox fun to finding one, rather than just for storage-sake.

[FlameArrow57]

For the wizard one, it would be really cool if on fail it swapped the item for a note saying "This item has been confiscated by the Space Wizard Federation" or something similar. I'd find it a hilarious fail

That'd be fun, though idk how much Wizards are tied to the artifacts in lore, and might change up the fail effects

[FlameArrow57]

Some of these should have a chance to spawn with a random array of items in them, akin to how beakers have random chems. Would add an additional layer of lootbox fun to finding one, rather than just for storage-sake.

Agree that'd be cool, was thinking that's a thing for the container artifacts, was trying to not do the same effect

[FlameArrow57]

Okay, added Martian storage, everything should work to what I tested, ready for re-review

Things from when this was last worked on

• Might just do away with the Precursor storage
• Not sure if there's too much in terms of the combining bags of holding effects
• Code is finished
• Sprites are still WIP

[github-actions]

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

[FlameArrow57]

Ready for review again