Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprites Sponge Capsules #14146

Merged
merged 4 commits into from Jul 19, 2023
Merged

Resprites Sponge Capsules #14146

merged 4 commits into from Jul 19, 2023

Conversation

TheColorCyan
Copy link
Contributor

@TheColorCyan TheColorCyan commented May 18, 2023

[GAME OBJECTS]

About the PR

Adds new sprites to Syndie sponge capsules and normal ones
S on syndie one clearly stands for sponge capsules
capsules

Why's this needed?

They needed a resprite

@boring-cyborg boring-cyborg bot added the C-Sprites Automatically applied on any .dmi or icons folder change label May 18, 2023
@keywordlabeler keywordlabeler bot added the A-Game-Objects The point of this PR is to deal with a specific game object label May 18, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2023
@CheffieGithub
Copy link
Contributor

can you show examples of the filled sprites with the overlay?

@TheColorCyan
Copy link
Contributor Author

they look like this in game
sprites
this

Copy link
Contributor

@flrsh flrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look very flat to me. Usually we try to have items in a quasi-3/4 perspective. If you're going more for a bag look, peach ring bags may be a good example to refer to. If you're going more for a box look, try cereal boxes or flour bags.

@TheColorCyan
Copy link
Contributor Author

These look very flat to me. Usually we try to have items in a quasi-3/4 perspective. If you're going more for a bag look, peach ring bags may be a good example to refer to. If you're going more for a box look, try cereal boxes or flour bags.

The old sprites and how they actually look IRL are actually flat and not a bag or a box so it barely makes any sense to me but I can try making it a box if you want
images (2)
Без названия (3)

@TheColorCyan
Copy link
Contributor Author

oh and on another note, when you try to put capsule back it doesn't let you with a message 'you try to put capsule back but it won't stay' which makes no sense if item was a bag/box

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 3, 2023
@pali6 pali6 requested a review from flrsh June 3, 2023 14:19
@pali6 pali6 removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 3, 2023
@flrsh
Copy link
Contributor

flrsh commented Jun 5, 2023

The issue is that the sprites look inconsistent with our style and giving them extra dimension would help. They're also too large. If you can think of a way to retain their blister pack aesthetic while making them fit our art style, that's fine. But otherwise, making them boxes might be easier.

@TheColorCyan
Copy link
Contributor Author

Yeah I can try
The issue with making them a box, as I already said before, would be it's interaction with a capsule after you remove it and try to put it back so it will probably have to be changed

@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jun 25, 2023
@github-actions github-actions bot removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 4, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for two weeks, and has been automatically marked as stale. This means it is at risk of being auto closed in another week. Please address any outstanding review items and ensure your PR is finished. If you are auto-staled anyway, ask developers if your PR will be merged. Once you have done any of the previous actions then you should request a developer remove the stale label on your PR, to reset the stale timer. If you feel no developer will respond in that time, you may wish to close this PR youself, while you seek developer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 18, 2023
@ZeWaka ZeWaka merged commit b6e4646 into goonstation:master Jul 19, 2023
21 checks passed
@ZeWaka ZeWaka removed the S-Stale An inactive PR that has had no updates in the past two weeks label Jul 19, 2023
@TheColorCyan TheColorCyan deleted the biocapsules branch July 19, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Sprites Automatically applied on any .dmi or icons folder change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants